On 6 October 2010 03:57, Niall Pemberton <niall.pember...@gmail.com> wrote: > On Wed, Oct 6, 2010 at 3:41 AM, sebb AT ASF <s...@apache.org> wrote: >> On 6 October 2010 03:36, <s...@apache.org> wrote: >>> Author: sebb >>> Date: Wed Oct 6 02:36:39 2010 >>> New Revision: 1004882 >>> >>> URL: http://svn.apache.org/viewvc?rev=1004882&view=rev >>> Log: >>> Make reader and encoding fields immutable >> >> Note: the same changes could be applied to the identically named class >> in the compatibility package, if required. >> However, that class will remain thread-hostile because of the mutable >> static field. > > The compatibility package is only in the "test" directory and just > intended to sanity check some of the refactoring I did. So I'd prefer > if possible it be left as close to its original state.
OK, makes sense. Might be worth adding a header comment to the file to record this information if the class is going to remain there for a while. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
