On 7 December 2010 03:10, Patrick Meyer <meyer...@gmail.com> wrote: > OK, I generated the patch file using Eclipse and it seems to have the > information you described. I'm not sure if the revision part is correct > though. The latest patch is named MATH-448.patch and it is now attached to > the JIRA issue, https://issues.apache.org/jira/browse/MATH-448. I hope this > latest file is what you need.
Almost there. I see my previous mail was misleading. I would expect most Commons developers to check out either a single project, e.g. https://svn.apache.org/repos/asf/commons/proper/math/trunk in which case a patch relative to the project will start like: Index: src/main/java/org/apache/commons/math/stat/Frequency.java =================================================================== --- src/main/java/org/apache/commons/math/stat/Frequency.java (revision 1042422) +++ src/main/java/org/apache/commons/math/stat/Frequency.java (working copy) etc. This is easy to apply. In Eclipse, select the project, then Team/Apply Patch. With the patch as currently attached, which starts: ### Eclipse Workspace Patch 1.0 #P apache-math Index: apache/commons/math/stat/Frequency.java =================================================================== --- apache/commons/math/stat/Frequency.java (revision 1042596) +++ apache/commons/math/stat/Frequency.java (working copy) etc. one first has to navigate to the directory "src/main/java/org" before applying the patch. Also, the patch has been done using the Eclipse Workspace as a Patch Root. Unfortunately, this is not portable, as it depends on the exact names given to the Eclipse projects. For example, I use 'commons-math' - you have used "apache-math" In future, please select Patch Root = Project in Eclipse. [Unfortunately it does not seem possible to make this the default.] However, no need to bother redoing this particular patch, but please bear in mind for any other patches. For example, it would be useful to have a test case that exercises the new method. This can be attached to the same JIRA (but with a different name, of course). > Thanks, > Patrick > > > > >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
