On 12 May 2011 09:07, <simonetrip...@apache.org> wrote: > Author: simonetripodi > Date: Thu May 12 08:07:43 2011 > New Revision: 1102197 > > URL: http://svn.apache.org/viewvc?rev=1102197&view=rev > Log: > since Digester is not thread safe, better switching from StringBuffer to > StringBuilder that's faster > > Modified: > commons/sandbox/digester3/trunk/src/examples/api/addressbook/Address.java > > commons/sandbox/digester3/trunk/src/examples/api/dbinsert/RowInserterRule.java > > commons/sandbox/digester3/trunk/src/examples/api/document-markup/MarkupDigester.java > > commons/sandbox/digester3/trunk/src/examples/plugins/pipeline/SubstituteTransform.java > > commons/sandbox/digester3/trunk/src/examples/xmlrules/addressbook/Address.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/BeanPropertySetterRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/CallMethodRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/CallParamRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/FactoryCreateRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/NodeCreateRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/ObjectCreateRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/ObjectParamRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/PathCallParamRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetNestedPropertiesRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetNextRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetPropertiesRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetPropertyRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetRootRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/SetTopRule.java > > commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/xmlrules/DigesterRuleParser.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/Address.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/Box.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/CallMethodRuleTestCase.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/Employee.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/LocationTrackerTestCase.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/ObjectParamRuleTestCase.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/OverlappingCallMethodRuleTestCase.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/SimpleTestBean.java > > commons/sandbox/digester3/trunk/src/test/java/org/apache/commons/digester3/plugins/TestXmlRuleInfo.java > > Modified: > commons/sandbox/digester3/trunk/src/examples/api/addressbook/Address.java > URL: > http://svn.apache.org/viewvc/commons/sandbox/digester3/trunk/src/examples/api/addressbook/Address.java?rev=1102197&r1=1102196&r2=1102197&view=diff > ============================================================================== > --- commons/sandbox/digester3/trunk/src/examples/api/addressbook/Address.java > (original) > +++ commons/sandbox/digester3/trunk/src/examples/api/addressbook/Address.java > Thu May 12 08:07:43 2011 > @@ -30,7 +30,7 @@ public class Address { > private String country; > > public String toString() { > - StringBuffer sb = new StringBuffer(); > + StringBuilder sb = new StringBuilder(); > sb.append( " address (type "+ type + ")\n"); > sb.append( " " + street + "\n"); > sb.append( " " + city + " " + state + " " + zip + "\n"); > @@ -39,7 +39,7 @@ public class Address { > } >
BTW, thread-safety is not an issue for local variables (unless you publish them e.g. by returning them). In this case, the StringBuilder is converted to a thread-safe String before publication. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
