Hi, Elijah-- I am neither a develop nor even a user of chain, so my comments will be high-level. Firstly, by all means upgrade to whatever JUnit 4 release version you like, e.g. 4.8.2. Next, I personally am a big fan of Mockito, so no complaints here on that account. I can't guarantee noone else would complain, but [chain] has been fairly unloved for a good while. As for JSF 2.1, is there something this achieves that wouldn't be equally well accomplished by simply upgrading to 2.0? This would give [chain]'s JSF support (which I personally hadn't realized existed) a potentially better combination of doing-things-that-couldn't-easily-be-done-with-older-APIs vs. broadest possible applicability.
Finally, as you don't seem to be a committer your final submission in this regard would be best recommended in the form of a JIRA issue, and your patches in (albeit large) patch form. In addition to this, the scope of these changes indicates it best IMO that you submit an Individual Contributor License Agreement governing your contributions to the ASF. See http://www.apache.org/licenses/#clas for details on how to do this. Regards and welcome, Matt On Sun, Aug 14, 2011 at 5:13 PM, Elijah Zupancic <eli...@zupancic.name> wrote: > I've just finished my proof of concept for an upgrade to Apache chain. > I would love to get this into a svn branch. I'm not quite sure what > the procedure is to do that, but the code can be found here for > review: > > http://elijah.zupancic.name/projects/commons-chain-v2-proof-of-concept.tar.gz > > And here is a diff: > > http://elijah.zupancic.name/projects/uber-diff > > At a high level, I have incorporated the following features in this > proof of concept: > > * Global upgrade to the JDK 1.5 > * Added @Override annotations > * Upgraded to the Servlet 2.5 API > * Upgraded to the Faces 2.1 API > * Upgraded to the Portlet 2.0 API > * Upgraded the Maven Parent POM version > * Added generics support to Command so that Command's API looks like: > > public interface Command<T extends Context> { > ... > boolean execute(T context) throws Exception; > } > > * Servlet and Portlet packages now provide Genericized APIs. > * All dicey changes have been marked with a comment with my name: (elijah) > > More or less the work to updated Chain was straight forward albeit > time consuming. > > If everyone is on board for this update, I would like to upgrade the > test cases to use a new version of JUnit. However, this leads to a few > questions: > > * What version of JUnit should I use? > * Would it be ok to use Mockito for mocking instead of the home grown > mocking classes already contained in the project? > > Please let me know what you think. Getting this far has been a couple > weeks worth of on and off work. > > Thanks, > -Elijah > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
