Why doesn't solve just return a RealMatrix? Why does it insist on returning an Array2DRowRealMatrix?
Does the user really care? 2011/9/8 Sébastien Brisard <[email protected]> > Hi Luc, > thanks for your detailed explanations attached to the MATH-659. I'm > worried about the changes I have applied to the code, now. Here is > what I've done. I've replaced the following line > {code} > return new Array2DRowRealMatrix(decomposition.getSolver().solve(b), false); > {code} > with > {code} > RealMatrix x = decomposition.getSolver().solve(new > Array2DRowRealMatrix(b, false)); > return new Array2DRowRealMatrix(x.getData(), false); > {code} > > decomposition is in fact an instance of QRDecompositionImpl.Solver, > whose method solve(RealMatrix) returns a BlockRealMatrix, not an > Array2DRowRealMatrix, hence the ugly last line. This code seems to be > correct (unit tests still pass), but I'm worried about the efficiency, > especially if initializeHighOrderDerivatives is called very often. > What do you think should be done? > > Best regards, > Sébastien > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
