it is now protected[1] but Clirr still complains... [1] $ svn annotate src/main/java/org/apache/commons/dbutils/AbstractQueryRunner.java ... 1184792 simonetripodi protected final DataSource ds; ...
http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Oct 16, 2011 at 1:03 PM, sebb <[email protected]> wrote: > On 16 October 2011 11:53, Simone Tripodi <[email protected]> wrote: >> Hi all guys, >> while fixing the violations emerged in last DbUtils RC, I noticed that >> the bigger part of QueryRunner code has been moved to >> AbstractQueryRunner and Clirr now complains that the 'ds' field in >> QueryRunner disappeared[1], but it would be available anyway! > > AbstractQueryRunner has: > private final DataSource ds; > which is not accessible. > >> Is that acceptable in order to submit a new RC or we have to find a >> way to fix the violation? > > This change to using a private field is an improvement; however it > will break any applications that rely on using it. > > What is the likelihood that applications will have been using the field? > >> TIA! >> Simo >> >> [1] >> http://people.apache.org/builds/commons/dbutils/1.4/RC2/site/clirr-report.html >> >> http://people.apache.org/~simonetripodi/ >> http://simonetripodi.livejournal.com/ >> http://twitter.com/simonetripodi >> http://www.99soft.org/ >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
