Hi Sebb, Sorry, -1: I get a build failure with my default set up using https://repository.apache.org/content/repositories/orgapachecommons-218/commons-net/commons-net/3.1/ *commons-net-3.1-src.zip*. The checkstyle XML files are missing.
Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) Maven home: C:\Java\apache-maven-3.0.4\bin\.. Java version: 1.6.0_29, vendor: Sun Microsystems Inc. Java home: C:\Program Files\Java\jdk1.6.0_29\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.0:site (default-site) on project commons-net: Error during page generation: Error re ndering Maven report: Failed during checkstyle execution: Unable to find configuration file at location C:\temp\*commons-net-3.1-src/checkstyle.xm*l: Could not fi nd resource 'C:\temp\commons-net-3.1-src/checkstyle.xml'. -> [Help 1] [ERROR] I also get this warning at the begining which sounds related: [WARNING] Some problems were encountered while building the effective model for commons-net:commons-net:jar:3.1 [WARNING] 'reporting.plugins.plugin.version' for org.codehaus.mojo:findbugs-maven-plugin is missing. @ line 340, column 21 [WARNING] Also, based on http://people.apache.org/~sebb/NET_3_1_RC1/site/: - Findbugs reports one issue. The code says: *//$FALL-THROUGH$ TODO change this if DEVICE_TYPE implemented * Is* $FALL-THROUGH$** *a special Findbugs comment designed to avoid avoid the issue being reported? Is it supposed to cause the issue to not be reported? - There are two checktyles reports! That is just plain weird. - On the site, there is a Javadoc link for 1.4.1 and 3.0.1 but nothing for 2.x, that seems inconsistent, not a blocker. - I wish the JIRAs had better titles, in the change report, I see "mlistDir doc should be "MLSD" not "MSLD". Fixes NET-441<http://issues.apache.org/jira/browse/NET-441>. Thanks to consiliens." which does not tell me when protocol this deals with. It would be nice if [net] tickets had a [protocol] prefix in the title. Not a blocker. On Fri, Feb 10, 2012 at 9:27 PM, sebb <seb...@gmail.com> wrote: > This is a vote to release Apache Commons NET 3.1 based on RC1. > > [ ] +1 release it > [ ] +0 go ahead I don't care > [ ] -1 no, do not release it because... > > tag: > https://svn.apache.org/repos/asf/commons/proper/net/tags/NET_3_1_RC1/(r1242993) > > site: > http://people.apache.org/~sebb/NET_3_1_RC1/site/ > > The Javadocs (1.4.1) link does not work, nor does the download link. > These will be OK once the site is deployed. > > Source and binary archives (tar.gz and .zip) and Maven jars: > https://repository.apache.org/content/repositories/orgapachecommons-218/ > > [The tar.gz and .zip files will be moved to dist/commons/net before > promoting the Maven jars to release status] > > Vote will remain open for at least 72 hours. > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
