On Mon, Mar 12, 2012 at 10:17 AM, Benedikt Ritter <benerit...@googlemail.com > wrote:
> Hey Gary, > > thanks for the hint. Should I just send patches for minor changes like > that to the ML (plain text, not as attachment of course ;)? > Hm, I thought a comitter was submitting these... JIRA is the way to submit code indeed. But note that the best way is to attach a diff file base on the SVN trunk. Gary > > Benedikt > > Am 12. März 2012 15:03 schrieb Gary Gregory <ggreg...@rocketsoftware.com>: > > I do not think we need to tickets for this kind of change. > > > > Gary > > > > On Mar 12, 2012, at 9:59, "Benedikt Ritter (Created) (JIRA)" < > j...@apache.org> wrote: > > > >> Replace while(true)-loop in CSVParser.getRecord() with do-while-loop > >> -------------------------------------------------------------------- > >> > >> Key: CSV-55 > >> URL: https://issues.apache.org/jira/browse/CSV-55 > >> Project: Commons CSV > >> Issue Type: Improvement > >> Components: Parser > >> Affects Versions: 1.0 > >> Reporter: Benedikt Ritter > >> Priority: Trivial > >> > >> > >> The current implementation of {{getRecords()}} uses a while(true) loop, > that gets canceled by an if statement: > >> > >> {code:java} > >> while (true) { > >> reusableToken.reset(); > >> lexer.nextToken(reusableToken); > >> // omitted > >> if(reusableToken.type != TOKEN) { > >> break; > >> } > >> } > >> {code} > >> > >> This should be replaced by a do-while-loop: > >> {code:java} > >> do { > >> reusableToken.reset(); > >> lexer.nextToken(reusableToken); > >> // omitted > >> } while (reusableToken.type == TOKEN); > >> {code} > >> > >> > >> -- > >> This message is automatically generated by JIRA. > >> If you think it was sent incorrectly, please contact your JIRA > administrators: > https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa > >> For more information on JIRA, see: > http://www.atlassian.com/software/jira > >> > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
