On 14 March 2012 21:02, Emmanuel Bourg <ebo...@apache.org> wrote:
> Le 14/03/2012 21:52, Benedikt Ritter a écrit :
>
>
>> the subject of this mail is pretty self-explanatory. Why do we need a
>> package private validate() method, given the fact, that users can not
>> create custom instances (constructor is package private)? You could
>> even argue, that no validation is needed at all, since we are in
>> control of what formats can be created. However I'd say, the
>> validation makes sure that we do not unintentionally create invalid
>> formats. But then validate() can be made private and called at the end
>> of the constructor.
>
>
> Because the format could temporarily be in an invalid state. Something like
> this would break (a bit far fetched, I agree):
>
> CSVFormat.DEFAULT.withDelimiter('#').withCommentStart('/');In which case, reversing the order would work. We would just have to document this as a restriction. The problem with leaving the validation until later is that it decouples the cause and effect. This makes it a bit harder to debug. It's also simpler if there is a single validation method. At present some of the setters also perform validation. BTW, we should probably reject delimiter == DISABLED. Also, the DISABLED constant needs to be public (or available via a public getter) otherwise it's not possible to disable all but the delimiter. Using a getter would allow the constant to be changed if it became necessary. > Emmanuel Bourg > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
