On 2012-07-08, sebb wrote: > On 7 July 2012 20:34, <bode...@apache.org> wrote: >> Modified: >> commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/ArchiveStreamFactory.java >>+ private String entryEncoding = null;
> The class is currently tagged as: > * @Immutable > This breaks the contract. > Can the field be made final? If we make it a constructor arg rather than a property. > Or turned into a parameter? This is slightly less convenient, I'm on the fence here. Jukka? Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
