On Mon, Jul 30, 2012 at 5:06 PM, Liviu Tudor <liviu.tu...@gmail.com> wrote:
> Hi Gary! > > See my previous email on pool which touches on that; I am experiencing the > same test failures and Mark just confirmed that the tests should be > changed. > > I'm currently in the process of submitting a patch for it -- hopefully no > one else is working on the same? (Or should I leave this to someone more > familiar with the [pool] code?) > Please go ahead. Gary > > > Liv > > Liviu Tudor > > E: liviu.tu...@gmail.com > C: +1 650-2833815 (USA) > M: +44 (0)7591540313 (UK, Europe) > W: http://about.me/liviutudor > Skype: liviutudor > > I'm nobody, nobody's perfect -- therefore I'm perfect! > > > > > > > > On 30/07/2012 14:04, "Gary Gregory" <garydgreg...@gmail.com> wrote: > > >Hi All: > > > >I wonder if this change: > > > >POOL-212. If minIdle > maxIdle use maxIdle in place of minIdle (rev > >1325476 > >by markt) > > > >broke the 4 tests below. > > > >Could the change be bogus or the tests need to be adjusted. > > > >My set up: > > > >Apache Maven 3.0.4 (r1232337; 2012-01-17 03:44:56-0500) > >Maven home: C:\Java\apache-maven-3.0.4\bin\.. > >Java version: 1.6.0_31, vendor: Sun Microsystems Inc. > >Java home: C:\Program Files\Java\jdk1.6.0_31\jre > >Default locale: en_US, platform encoding: Cp1252 > >OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows" > > > >test (2) > >org.apache.commons.pool.impl.TestGenericObjectPoolClassLoaders > >testContextClassLoader(org.apache.commons.pool.impl.TestGenericObjectPoolC > >lassLoaders) > >junit.framework.AssertionFailedError: Wrong number of idle objects in > >pool1 > >expected:<1> but was:<0> > > at junit.framework.Assert.fail(Assert.java:50) > > at junit.framework.Assert.failNotEquals(Assert.java:287) > > at junit.framework.Assert.assertEquals(Assert.java:67) > > at junit.framework.Assert.assertEquals(Assert.java:199) > > at > >org.apache.commons.pool.impl.TestGenericObjectPoolClassLoaders.testContext > >ClassLoader(TestGenericObjectPoolClassLoaders.java:46) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > > at java.lang.reflect.Method.invoke(Unknown Source) > > at junit.framework.TestCase.runTest(TestCase.java:168) > > at junit.framework.TestCase.runBare(TestCase.java:134) > > at junit.framework.TestResult$1.protect(TestResult.java:110) > > at junit.framework.TestResult.runProtected(TestResult.java:128) > > at junit.framework.TestResult.run(TestResult.java:113) > > at junit.framework.TestCase.run(TestCase.java:124) > > at junit.framework.TestSuite.runTest(TestSuite.java:243) > > at junit.framework.TestSuite.run(TestSuite.java:238) > > at > >org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit > >3TestReference.java:130) > > at > >org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java > >:38) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:467) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:683) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunne > >r.java:390) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunn > >er.java:197) > > > >org.apache.commons.pool.impl.TestGenericObjectPoolFactory > >testConstructors(org.apache.commons.pool.impl.TestGenericObjectPoolFactory > >) > >junit.framework.AssertionFailedError: expected:<4> but was:<2> > > at junit.framework.Assert.fail(Assert.java:50) > > at junit.framework.Assert.failNotEquals(Assert.java:287) > > at junit.framework.Assert.assertEquals(Assert.java:67) > > at junit.framework.Assert.assertEquals(Assert.java:199) > > at junit.framework.Assert.assertEquals(Assert.java:205) > > at > >org.apache.commons.pool.impl.TestGenericObjectPoolFactory.testConstructors > >(TestGenericObjectPoolFactory.java:67) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > > at java.lang.reflect.Method.invoke(Unknown Source) > > at junit.framework.TestCase.runTest(TestCase.java:168) > > at junit.framework.TestCase.runBare(TestCase.java:134) > > at junit.framework.TestResult$1.protect(TestResult.java:110) > > at junit.framework.TestResult.runProtected(TestResult.java:128) > > at junit.framework.TestResult.run(TestResult.java:113) > > at junit.framework.TestCase.run(TestCase.java:124) > > at junit.framework.TestSuite.runTest(TestSuite.java:243) > > at junit.framework.TestSuite.run(TestSuite.java:238) > > at > >org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit > >3TestReference.java:130) > > at > >org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java > >:38) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:467) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:683) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunne > >r.java:390) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunn > >er.java:197) > > > >org.apache.commons.pool.impl.TestGenericKeyedObjectPoolFactory > >testConstructors(org.apache.commons.pool.impl.TestGenericKeyedObjectPoolFa > >ctory) > >junit.framework.AssertionFailedError: expected:<4> but was:<2> > > at junit.framework.Assert.fail(Assert.java:50) > > at junit.framework.Assert.failNotEquals(Assert.java:287) > > at junit.framework.Assert.assertEquals(Assert.java:67) > > at junit.framework.Assert.assertEquals(Assert.java:199) > > at junit.framework.Assert.assertEquals(Assert.java:205) > > at > >org.apache.commons.pool.impl.TestGenericKeyedObjectPoolFactory.testConstru > >ctors(TestGenericKeyedObjectPoolFactory.java:64) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > > at java.lang.reflect.Method.invoke(Unknown Source) > > at junit.framework.TestCase.runTest(TestCase.java:168) > > at junit.framework.TestCase.runBare(TestCase.java:134) > > at junit.framework.TestResult$1.protect(TestResult.java:110) > > at junit.framework.TestResult.runProtected(TestResult.java:128) > > at junit.framework.TestResult.run(TestResult.java:113) > > at junit.framework.TestCase.run(TestCase.java:124) > > at junit.framework.TestSuite.runTest(TestSuite.java:243) > > at junit.framework.TestSuite.run(TestSuite.java:238) > > at > >org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit > >3TestReference.java:130) > > at > >org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java > >:38) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:467) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:683) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunne > >r.java:390) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunn > >er.java:197) > > > >org.apache.commons.pool.impl.TestGenericKeyedObjectPool > >testConstructors(org.apache.commons.pool.impl.TestGenericKeyedObjectPool) > >junit.framework.AssertionFailedError: expected:<4> but was:<2> > > at junit.framework.Assert.fail(Assert.java:50) > > at junit.framework.Assert.failNotEquals(Assert.java:287) > > at junit.framework.Assert.assertEquals(Assert.java:67) > > at junit.framework.Assert.assertEquals(Assert.java:199) > > at junit.framework.Assert.assertEquals(Assert.java:205) > > at > >org.apache.commons.pool.impl.TestGenericKeyedObjectPool.testConstructors(T > >estGenericKeyedObjectPool.java:1069) > > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) > > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) > > at java.lang.reflect.Method.invoke(Unknown Source) > > at junit.framework.TestCase.runTest(TestCase.java:168) > > at junit.framework.TestCase.runBare(TestCase.java:134) > > at junit.framework.TestResult$1.protect(TestResult.java:110) > > at junit.framework.TestResult.runProtected(TestResult.java:128) > > at junit.framework.TestResult.run(TestResult.java:113) > > at junit.framework.TestCase.run(TestCase.java:124) > > at junit.framework.TestSuite.runTest(TestSuite.java:243) > > at junit.framework.TestSuite.run(TestSuite.java:238) > > at > >org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit > >3TestReference.java:130) > > at > >org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java > >:38) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:467) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTest > >Runner.java:683) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunne > >r.java:390) > > at > >org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunn > >er.java:197) > > > > > > > >-- > >E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > >JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 > >Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK > >Blog: http://garygregory.wordpress.com > >Home: http://garygregory.com/ > >Tweet! http://twitter.com/GaryGregory > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
