On 08/27/2012 03:36 PM, Gary Gregory wrote: > Hi All: > > FindBugs says the following a couple of times for UnixCrypt: > "Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION) > > This is an integer bit operation (and, or, or exclusive or) that doesn't do > any useful work (e.g., v & 0xffffffff)." > This makes me wonder if the whole class is correct in the first place and > if/how/why these ops got in there. > > Was this translated (incorrectly) from JetSpeed's implementation? Where the > types (int vs longs?) in JetSpeed different? Where did JetSpeed get this > implementation?
I do not know the source of the JetSpeed implementation, but there are several (slightly different) variants of this floating around in other projects: http://grepcode.com/file/repository.jboss.org/maven2/postgresql/postgresql/8.4-701.jdbc3/org/postgresql/util/UnixCrypt.java http://grepcode.com/file/repo1.maven.org/maven2/org.mortbay.jetty/jetty/6.1.11/org/mortbay/jetty/security/UnixCrypt.java The jetty version looks the most clean one, and as it is also Apache license, maybe we should take this one and cleanup the code a bit? Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
