> > >
> > > FindBugs can give warnings like:
> > >
> > > Switch statement found in
> > > org.apache.commons.codec.binary.Base32.decode(byte[], int, int,
> > > BaseNCodec$Context) where default case is missing
> > >
> > > In this case for [codec], it looks like the code was carefully
> > constructed
> > > and that no default clause is needed.
> > >
> > > In these cases for any component, this FindBugs issue feels like a style
> > > issue, is it worth changing the code to add a default clause like:
> > >
> > > default:
> > > // ok to fall through for other values.
> > > break;
> > >
> > > Or does this feel like noise to you all?
> >
> > In Math, there is this kind of code:
> > ---CUT---
> > switch (method) {
> > case ILLINOIS:
> > f0 *= 0.5;
> > break;
> > case PEGASUS:
> > f0 *= f1 / (f1 + fx);
> > break;
> > case REGULA_FALSI:
> > // Detect early that algorithm is stuck, instead of
> > // waiting
> > // for the maximum number of iterations to be exceeded.
> > if (x == x1) {
> > throw new ConvergenceException();
> > }
> > break;
> > default:
> > // Should never happen.
> > throw new MathInternalError();
> > }
> > ---CUT---
> >
> >
> What about the opposite case:
>
> We do not care about the other values than the ones in each switch case.
>
Wouldn't adding an empty "default" be enough to mean that (and silence
FindBugs)?
Regards,
Gilles
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
