On Mon, Sep 17, 2012 at 2:19 PM, Duncan Jones <[email protected]> wrote:
> On 17 September 2012 19:13, Duncan Jones <[email protected]> wrote: > > On 17 September 2012 19:07, Gary Gregory <[email protected]> wrote: > >> On Mon, Sep 17, 2012 at 2:03 PM, Matt Benson <[email protected]> > wrote: > >> > >>> Hello, > >>> We'd love to have our whole testsuite updated to JUnit 4, IMO. The > >>> only thing is that as a rule we'd rather that changeset be separate > >>> from another, so I'd recommend providing multiple patches, possibly > >>> submitted in separate JIRA issues. > >>> > >> > >> +1! > >> > >> Patch 1: Update to JUnit 4 > >> Patch 2: the patch > > > > No problem, I like that approach. > > On second thought, how would I best accomplish this? If I create a > patch after converting the test case, then create another patch after > fixing the issue, the latter patch will contain the changes from the > first patch. Is this ok with everyone? Or is there some patch > difference tool I should know about? > Hm, then first step should be to make sure that @Override is implemented all over to get compile errors when removing "extends TestCase". I've done it manually in the past, on a class by class basis as I touched test classes. Doing it all at once would be nice of course. Gary > > Duncan > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
