Hi Sebb, I'm getting on the road, I'll try to get back to you late tonight (EST).
Gary On Mon, Oct 15, 2012 at 11:12 AM, sebb <[email protected]> wrote: > On 13 October 2012 18:20, <[email protected]> wrote: > > Author: ggregory > > Date: Sat Oct 13 17:20:04 2012 > > New Revision: 1397904 > > > > URL: http://svn.apache.org/viewvc?rev=1397904&view=rev > > Log: > > Javadoc. > > > > Modified: > > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java > > > > Modified: > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java > > URL: > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java?rev=1397904&r1=1397903&r2=1397904&view=diff > > > ============================================================================== > > --- > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java > (original) > > +++ > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVLexer.java > Sat Oct 13 17:20:04 2012 > > @@ -27,7 +27,7 @@ import java.io.IOException; > > > > class CSVLexer extends Lexer { > > > > - // ctor needs to be public so can be called dynamically by > PerformanceTest class > > + /** ctor needs to be public so can be called dynamically by > PerformanceTest class */ > > public CSVLexer(final CSVFormat format, final > ExtendedBufferedReader in) { > > super(format, in); > > } > > Probably ought to find a better way to achieve this; e.g. add helper > class in same package. > > If not, the Javadoc needs to make very clear that this is not part of > the public API. > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
