On 19 January 2013 14:09, <[email protected]> wrote:
> Author: tn
> Date: Sat Jan 19 14:09:52 2013
> New Revision: 1435550
>
> URL: http://svn.apache.org/viewvc?rev=1435550&view=rev
> Log:
> Fix checkstyle warnings.
>
> Modified:
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32InputStream.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base32OutputStream.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64InputStream.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/Base64OutputStream.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/BaseNCodec.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/binary/StringUtils.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/B64.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/Sha2Crypt.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/DoubleMetaphone.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/PhoneticEngine.java
>
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/language/bm/Rule.java
>
> Modified:
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java?rev=1435550&r1=1435549&r2=1435550&view=diff
> ==============================================================================
> ---
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
> (original)
> +++
> commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/StringEncoderComparator.java
> Sat Jan 19 14:09:52 2013
> @@ -28,6 +28,7 @@ import java.util.Comparator;
> *
> * @version $Id$
> */
> +@SuppressWarnings("rawtypes")
-1
That is not a checkstyle warning.
Suppression of generics warnings should only be done if it is not
possible to fix the warning AND the warning is a false positive.
If so, then a // comment should be added to the line saying why it is
safe to suppress the warning.
> public class StringEncoderComparator implements Comparator {
>
> /**
> @@ -69,6 +70,7 @@ public class StringEncoderComparator imp
> * @return the Comparable.compareTo() return code or 0 if an encoding
> error was caught.
> * @see Comparable
> */
> + @SuppressWarnings("unchecked")
-1, as above
> @Override
> public int compare(final Object o1, final Object o2) {
>
{snip]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
