I agree with sebb. Imports should only be added if they are needed in the code.
Send from my mobile device Am 18.03.2013 um 23:28 schrieb sebb <seb...@gmail.com>: > It's still misleading to have the import listed, as it's useful to be > able to do a text search to find where a specific class is used. > Obviously this does not show java.lang usages or references to classes > in the same package, but it's still useful (and quick). > > On 18 March 2013 21:51, Gary Gregory <garydgreg...@gmail.com> wrote: >> Hm... I consider this a bug in checkstyle or whatever does the >> complaining... >> >> Gary >> >> >> On Mon, Mar 18, 2013 at 5:30 PM, sebb <seb...@gmail.com> wrote: >> >>> On 18 March 2013 18:45, <ggreg...@apache.org> wrote: >>>> Author: ggregory >>>> Date: Mon Mar 18 18:45:56 2013 >>>> New Revision: 1457915 >>>> >>>> URL: http://svn.apache.org/r1457915 >>>> Log: >>>> Fix Javadoc. >>>> >>>> Modified: >>> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java >>>> >>>> Modified: >>> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java >>>> URL: >>> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java?rev=1457915&r1=1457914&r2=1457915&view=diff >>> ============================================================================== >>>> --- >>> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java >>> (original) >>>> +++ >>> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java >>> Mon Mar 18 18:45:56 2013 >>>> @@ -27,6 +27,7 @@ import java.util.List; >>>> import java.util.Set; >>>> >>>> import org.apache.commons.collections.CollectionUtils; >>>> +import org.apache.commons.collections.collection.CompositeCollection; >>> >>> This can cause "unused import" complaints and is misleading about what >>> the class actually needs. >>> I think it's better to qualify the Javadoc. >>> >>>> import org.apache.commons.collections.iterators.EmptyIterator; >>>> import org.apache.commons.collections.iterators.IteratorChain; >>>> import org.apache.commons.collections.list.UnmodifiableList; >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >>> For additional commands, e-mail: dev-h...@commons.apache.org >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0 >> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
