The format field in Lexer is now only used by CSVLexer1 in the test directory. It may therefore be removed. I wonder if the isXXX methods really belong to CSVFormat.
WDYT? Benedikt 2013/5/3 <[email protected]> > Author: britter > Date: Fri May 3 06:37:58 2013 > New Revision: 1478655 > > URL: http://svn.apache.org/r1478655 > Log: > Use isDelimiter method instead of != check. > > Modified: > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > > Modified: > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > URL: > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java?rev=1478655&r1=1478654&r2=1478655&view=diff > > ============================================================================== > --- > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > (original) > +++ > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > Fri May 3 06:37:58 2013 > @@ -146,7 +146,7 @@ abstract class Lexer { > * @return true if the given char is a whitespace character > */ > boolean isWhitespace(final int c) { > - return c != format.getDelimiter() && > Character.isWhitespace((char) c); > + return !isDelimiter(c) && Character.isWhitespace((char) c); > } > > /** > > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
