+1 BUT the following are not blockers but should be improved if another RC is cut: - Low (27%) code coverage for the new class https://commons.apache.org/proper/commons-compress/cobertura/org.apache.commons.compress.archivers.arj.ArjArchiveEntry.html - PMD violations in new code, for example ArjArchiveInputStream. - The change report should have the date of the RC instead of "not released, yet". - Using the live site for the RC is a bad idea IMO because the source will have to be changed to update the version, for example "The current release is 1.5." and "Commons Compress 1.5 requires Java 5" and who knows what else will have to be changed. This means that what is in the RC is NOT building the 1.6 site, it is building a SNAPSHOT site. - Site overview page: I do not want to read a history lesson ('The code in this component has many origins:') first, please tell me how to use the software first, then at the bottom, I can read about history. - Site overview page: too much redundant information (should be collapsed into one place): - Status (1st line): The current release is 1.5. - Documentation (1st line): Commons Compress 1.5 requires Java 5. - Releases (1st line): The latest version v1.5, is Java5 compatible And it is all about 1.5 instead of 1.6! See above. - Add a "What's new in 1.6" section instead of burying the information in the middle of the text: "As of Commons Compress 1.6 support for the dump and arj formats is read-only".
For me, I would do another RC but these are not hard core blockers. Gary On Sun, Oct 13, 2013 at 1:31 AM, Stefan Bodewig <bode...@apache.org> wrote: > Hi > > since Compress 1.5 we've fixed a few bugs but most notably added > read-only support for LZMA standalone, uncompressed ARJ and full support > for 7z. > > I have not created a RC website as the only difference to the current > website would be the download page and the version number - and I'd > immediately change the site after the release to include the release > date anyway. > > Foo 1.2 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/compress/ > (svn revision 3254) > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-167/org/apache/commons/commons-compress/1.6/ > > Details of changes since 1.5 are in the release notes: > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.6-RC1/RELEASE-NOTES.txt > > The tag is here: > > https://svn.apache.org/repos/asf/commons/proper/compress/tags/COMPRESS-1.6-RC1/ > (svn revision 1531616) > > Site: > http://commons.apache.org/compress/ > > Clirr Report (compared to 1.5): > http://commons.apache.org/compress/clirr-report.html > > RAT Report: > http://commons.apache.org/compress/rat-report.html > > KEYS: > http://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, i.e. after 0530 > GMT 16-October 2013 - given that I'll be traveling the second half of > this week I'd rather expect the release to happen next Saturday. > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
