On Sat, Oct 19, 2013 at 5:51 PM, Phil Steitz <[email protected]> wrote: > Investigation / tests / documentation much appreciated. > > Thanks for looking into this!
OK Phil I'll have another go. I would like to propose three patches (three JIRAs?) 1. The javadoc updates discussed on this thread, which I really wouldn't mind someone else reviewing for correctness. Plus a few additional tests to cover the gaps between what's tested now and what's being asserted in the javadoc. 2. A small issue in EigenDecomposition.isNonSingular() that I found while making a test for it (so won't be part of patch #1). Basically it needs to use the "epsilon" threshold for testing for 0 eigenvalues to get this right reliably. 3. If it turns out to be a real issue, a patch for QRDecompositionSolver to handle tall/skinny matrices correctly. Still need to look into this to be sure. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
