2014-02-02 Gary Gregory <[email protected]>:

> Unfortunately the skin does not look good on a mobile:
>
>
> http://www.thepicturebin.com/images/garygregory/tmpscreenshot201402021018331281933124.jpg
>
>
> http://www.thepicturebin.com/images/garygregory/tmpscreenshot2014020210183764912765.jpg


Yes, I see... Not very good, although its okay in landscape mode.
Is this a -1 from you or can we release this and fix mobile clients in 4.1?

Benedikt


>
>
> Gary
>
> -------- Original message --------
> From: Benedikt Ritter <[email protected]>
> Date:02/02/2014  06:58  (GMT-05:00)
> To: Commons Developers List <[email protected]>
> Subject: [VOTE][LAZY] Release commons-skin-4 based on RC1
>
> Hi all,
>
> I've integrated the changes Thomas Neidhart made to commons-skin in his
> github repo [1] into trunk. Commons Skin now uses bootstrap for rendering,
> which would give our sites a fresh new appearance. So I'd like to call a
> vote by lazy consensus to release commons-skin-4 based on RC1.
>
> The files:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1004
>
> The tag:
>
>
> https://svn.apache.org/repos/asf/commons/proper/commons-skin/tags/commons-skin-4-RC1
>
> The site:
>
> none.
>
> Some examples:
>
> http://people.apache.org/~britter/commons-sites-fluido/cms-site
> http://people.apache.org/~britter/commons-sites-fluido/commons-codec
> http://people.apache.org/~britter/commons-sites-fluido/commons-collections
> http://people.apache.org/~britter/commons-sites-fluido/commons-lang
>
> Instructions to try it out yourself:
>
> - checkout the tag
> - mvn clean install the tag
> - checkout commons-parent
> - change the site.xml in commons-parent to use commons-skin-4
> - mvn clean install the parent
> - change pom.xml of the component you want to build to use commons-parent
> 33-SNAPSHOT
> - mvn clean site
>
>
> This VOTE by LAZY-CONSENSUS is open for at least 72 hours. It will finish
> no earlier than February 5 at 13:00 CET.
>
> No need to vote unless you think there is a problem, in which case please
> vote -1 and explain what the issue is.
>
> Thanks!
> Benedikt
>
> [1] https://github.com/netomi/commons-skin-fluido
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Reply via email to