Hello Bernd, many thanks for your detailed review. Here are my comments:
2014-05-04 21:11 GMT+02:00 Bernd Eckenfels <e...@zusammenkunft.net>: > Hello, > > I did some chekcs on the CSV trunk cause you mentioned a release is > coming up (and I feel its a bad feeling to get no external reviews for > releases). Here are my findings: > > - compiling with Java 8 and maven 3.2.1 on Windows works, but the site > goal fails (findbugs porblem) > I've already encounters this one in [lang]. It looks like this can only be fixed after the next FindBugs version has been release (2.1.0) and there does not seem to be a schedule for this. But I'll add a special note to the site. > > - site: produces the "there are no official downloads, and will > nut until version 1.0 is released". I guess this has to be changed > before release. (some other places as well) > The download website will be created as part of the release process. > > - site: reportin bugs -> "commons sandbos project" - looks like it has > its own JIRA component already? > fixed > > - site: team: 3 members with no avatars (mvdb, yonik, ggregory) > this works via gravatar. So people are free to choose whether they want an avatar or not. > > - site: Netcetera company is mentioned in the "About" history page but > not in the contributors. The 3 projects which are intentet to be > obsoleted, is that message still agreed by them? Maybe all 3 authors > should approve the release as well? > I'm not sure about this paragraph at well, but since I don't know the history, I'll leave it as it is for now. > > - pom: display-plugin-updates: would be possible to update checkstyle > from 1.12 to 1.12.1 > fixed. > > - pom: display-dependency-updates: commons.io 2.2->2.4 and h2 > 1.3.168->1.4.178. Both are explained in the POM as last 1.5 > dependency. Will we ship it as 1.5? > for now we want to be compatible with 1.5. Since those are just test dependencies, I think they can stay that way. > > - site/report: jira-report shows only one issue for 1.x, change to 1.0? > (csv-64) > The Jira report is auto generated, and I don't really trust it. I don't plan to do any further development, since CSV has been close to 1.0 for so long, that I think it's stable enough to be released as it is. Remember: release early, release often. > > - checkstyle: one linebreak error > fixed. > > - parse(final File file, final CSVFormat format): as FindBugs complains > it uses the default encoding in file reader. I can understand that > this is for compatibility reasons but it is not at all mentioned in > the javadoc. > I've documented the behavior. > > - there are 10 TODO tags in the source? > yes. If you have time to fix those, help is more than welcome :-) As for the open tickets, I think we can release anyway. > > - pom: there is one comment about using checkstyle 2.9.1 instead of > 2.10 but the actual property is 2.12? -> remove comment? > I've removed it. > > - pom: the javancss plugin seems to have a problem with maven 2, will > we document minimum of maven 3.0.5? > To be honest: I don't have a maven 2.x installation on my machine. Since the javancss plugin in only used for the project reports (and thou only affects the site build) I think this restriction isn't necessary. > > - pom: how will the release (assembly) be triggered? > RM magic ;-) I'll figure that out, once it dive into the creation of the RC. > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
