On 06/28/2014 03:27 PM, Gary Gregory wrote: > On Sat, Jun 28, 2014 at 9:25 AM, Gary Gregory <garydgreg...@gmail.com> > wrote: > >> On Sat, Jun 28, 2014 at 9:23 AM, Gary Gregory <garydgreg...@gmail.com> >> wrote: >> >>> On Sat, Jun 28, 2014 at 9:01 AM, Thomas Neidhart < >>> thomas.neidh...@gmail.com> wrote: >>> >>>> On 06/28/2014 02:45 PM, Gary Gregory wrote: >>>>> So -1 because the pmd.xml file is missing from the src zip. >>>> >>>> r1484126 | ggregory | 2013-05-18 17:15:22 +0200 (Sat, 18 May 2013) | 1 >>>> line >>>> >>> > and wow, we have not cut a release in a long time or checked the build from > the src zip!
the last release was about 1 1/4 years ago. Since then the pmd and findbugs reports have been added without properly checking that the release build still is complete. Ok can happen. >>>> Add FindBugs and PMD reports. >>>> >>>> >>>> Ha, you added the reports, and I did not notice it. That is unfortunate. >>>> btw. I did disable the findbugs report again as it was mainly creating >>>> false positives and I did not want to spend the time adding exclude >>>> filters. >>>> >>> >>> Hm... I like having the reports as ideas for fixing things if I am idle >>> or to give others ideas on how to get their feet wet with small changes. sure, if time permits it, but it should not block the release for a component that is unchanged for years. >> I just added the pmd.xml to the src assembly in trunk. ok thanks. Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
