hmm, I do not know what I have seen yesterday, but the references to dbcp 2.x and pool 2.3 are already correct.
I have updated the other 2 examples to use an h2 database as already outlined in the PoolingDataSourceExample. Thomas On Wed, Feb 18, 2015 at 1:13 AM, Phil Steitz <phil.ste...@gmail.com> wrote: > On 2/17/15 2:29 PM, Thomas Neidhart wrote: > > On 02/17/2015 05:04 AM, Phil Steitz wrote: > >> Quite a few bugs have been fixed since DBCP 2.0.1 and a few new > >> features have been added. It is time for a 2.1 release. > >> > >> The release is available for review here: > >> https://dist.apache.org/repos/dist/dev/commons/dbcp (r8031) > >> > >> The release was built from this tag: > >> http://svn.apache.org/viewvc/commons/proper/dbcp/tags/DBCP_2_1_RC1 > >> (r1660242) > >> > >> Release notes: > >> https://dist.apache.org/repos/dist/dev/commons/dbcp/RELEASE-NOTES.txt > >> > >> Maven artifacts: > >> > https://repository.apache.org/content/repositories/orgapachecommons-1082 > >> > >> Site: > >> http://people.apache.org/~psteitz/dbcp/dbcp-2.1-RC1-site/ > >> > >> KEYS: > >> http://www.apache.org/dist/commons/KEYS > >> > >> Votes, please. > >> > >> This vote will close no sooner than 72 hours from now. > > [x] +1 Release these artifacts > > > > Tested successfully within the following environment: > > > > $ mvn -version > > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 > > 17:22:22+0200) > > Maven home: /home/tn/bin/apache-maven-3.1.1 > > Java version: 1.7.0_75, vendor: Oracle Corporation > > Java home: /usr/lib/jvm/java-7-openjdk-i386/jre > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "linux", version: "3.13.0-37-generic", arch: "i386", family: > "unix" > > > > One small nit that I found: > > > > while trying to run the examples with the jar I noticed that at least > > two of the examples still contain instructions for dbcp 1.x. > > Drat. I thought I had fixed them all... > > > > I would also update the examples to use a small self-contained, > > in-memory database like hsqldb which makes it easier to quickly test it > > (I can also update the example code post-release myself). > > By all means, have at it! The examples on the web site are just > sourced directly from svn, so fixes become immediately available. > > Thanks! > > Phil > > > > Thomas > > > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> Thanks! > >> > >> Phil > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
