On 5/18/15 11:41 PM, Benedikt Ritter wrote: > 2015-05-19 8:24 GMT+02:00 Mark Thomas <[email protected]>: > >> On 19/05/2015 01:51, sebb wrote: >>> On 19 May 2015 at 00:45, Phil Steitz <[email protected]> wrote: >>>> On 5/18/15 4:40 PM, [email protected] wrote: >>>>> Author: ggregory >>>>> Date: Mon May 18 23:40:21 2015 >>>>> New Revision: 1680133 >>>>> >>>>> URL: http://svn.apache.org/r1680133 >>>>> Log: >>>>> [POOL-295] Update tests from JUnit 4.11 to 4.12. >>>>> >>>>> Modified: >>>>> commons/proper/pool/trunk/pom.xml >>>>> commons/proper/pool/trunk/src/changes/changes.xml >>>>> >>>>> Modified: commons/proper/pool/trunk/pom.xml >>>>> URL: >> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1680133&r1=1680132&r2=1680133&view=diff >> ============================================================================== >>>>> --- commons/proper/pool/trunk/pom.xml (original) >>>>> +++ commons/proper/pool/trunk/pom.xml Mon May 18 23:40:21 2015 >>>>> @@ -117,7 +117,7 @@ >>>>> <dependency> >>>>> <groupId>junit</groupId> >>>>> <artifactId>junit</artifactId> >>>>> - <version>4.11</version> >>>>> + <version>4.12</version> >>>>> <scope>test</scope> >>>>> </dependency> >>>>> <dependency> >>>>> >>>>> Modified: commons/proper/pool/trunk/src/changes/changes.xml >>>>> URL: >> http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/changes.xml?rev=1680133&r1=1680132&r2=1680133&view=diff >> ============================================================================== >>>>> --- commons/proper/pool/trunk/src/changes/changes.xml (original) >>>>> +++ commons/proper/pool/trunk/src/changes/changes.xml Mon May 18 >> 23:40:21 2015 >>>>> @@ -70,6 +70,9 @@ The <action> type attribute can be add,u >>>>> <action dev="psteitz" type="add" issue="POOL-286"> >>>>> Added preparePool method to GenericObjectPool. >>>>> </action> >>>>> + <action dev="ggregory" type="update" issue="POOL-295"> >>>>> + Update tests from JUnit 4.11 to 4.12. >>>>> + </action> >>>> I don't think we need this kind of change documented in the release >>>> notes. >>> Agreed. Nor is a JIRA really necessary. >> Disagreed. It is a change and it should be documented. >> > But a change in test dependencies will not (or at least should not ;-) have > any effect on clients. So why clutter release notes with this kind of > changes?
That was my point. What goes in changes.xml is what goes into the release notes. Personally, I don't think updating test dependencies belongs in there. If others disagree, I am OK erring on the side of inclusion when it comes to release notes. Phil > > >> I do agree a Jira isn't really necessary but I've no objection to one >> being created if that is a contributors preferred way of working. >> >> Mark >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
