On 5/22/15 8:10 PM, Bruno P. Kinoshita wrote: > Build works fine in > > Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; > 2014-12-15T06:29:23+13:00) > Maven home: /opt/apache-maven-3.2.5 > Java version: 1.8.0_45, vendor: Oracle Corporation > Java home: /usr/lib/jvm/java-8-oracle/jre > Default locale: en_US, platform encoding: UTF-8 > OS name: "linux", version: "3.16.0-38-generic", arch: "amd64", family: "unix" > Rat reports 1 binary, against 2 binaries from the previous web site. I think > it is because the previous version included site.tgz in the report. One new > error in checkstyle, but that doesn't seem relevant. > This version introduces five errors in FindBugs, all related to the same type > [1] > > I've changed locally a part of the code reported by FindBugs > (GenericKeyedObjectPool L755). From > for (K k : poolMap.keySet()) { > ObjectDeque<T> queue = poolMap.get(k); > To > > for (Map.Entry<K, ObjectDeque<T>> entry : poolMap.entrySet()) { > ObjectDeque<T> queue = entry.getValue(); > Running the build again, all tests pass and the FindBugs error is gone. But > I'm not sure if it wasn't intentional to avoid stale reads from the map. > Could anyone confirm if the errors reported by FindBugs can be ignored, > please?
Yes, "fixing" this would be a bad idea. It is a false positive. If there is another RC, I will add a suppression filter for this "bug" that must be due to findbugs version upgrade. Otherwise, this can be added post-release as part of the site update. Thanks for the review! Phil > Thanks!Bruno > > http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR > > > From: Phil Steitz <phil.ste...@gmail.com> > To: Commons Developers List <dev@commons.apache.org> > Sent: Saturday, May 23, 2015 3:51 AM > Subject: [VOTE] Release pool 2.4 based on RC1 > > This is a vote to release version 2.4 of Apache Commons Pool based > on RC1. > > Here is the release candidate: > https://dist.apache.org/repos/dist/dev/commons/pool/ > (r9083) > > Built from: > https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_4_RC1/ > (r1680963) > > Release notes: > https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt > > Maven artifacts: > http://s.apache.org/Va6 > > site: > http://people.apache.org/~psteitz/pool/pool-2.4-rc1 > > keys: > > https://www.apache.org/dist/commons/KEYS > > Votes, please. > > This vote will close no sooner that 72 hours from now (15:50 GMT > 25-May-2015). > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > Phil > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org