Hello Oliver, I've commented on LANG-1141. Your patch looks good to me.
Benedikt 2015-06-09 7:26 GMT+02:00 Benedikt Ritter <[email protected]>: > Hello Oliver, > > I need some more time to look into this. Sorry, I'm pretty busy at the > moment :-( > > br, > Benedikt > > 2015-06-01 22:25 GMT+02:00 Oliver Heger <[email protected]>: > >> Hi, >> >> I just tried to update the [lang] dependency in [configuration] from >> 3.3.2 to 3.4. However, after this switch there are a bunch of test >> failures. >> >> AFAICT, these errors are related to string substitution. Variables in a >> string used to locate a configuration file are suddenly no longer >> replaced. Browsing the change report, this seems to be related to >> LANG-1055. IIUC, the lookup object for system properties is now >> initialized with a copy of the current system properties. The tests in >> [configuration] change system properties after creating the object. >> These changes are now no longer reflected. >> >> How should we handle this? >> Oliver >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter
