Chas, Thank you for preparing a release candidate.
-1 RAT says some license header are off: https://people.apache.org/~chas/bcel-6.0-RC4/rat-report.html @author tags should be removed. Also, you need to provide a Clirr report based on the old package name posted somewhere, so we can see what the BC breakage is and if the package name change is required. Long list of FindBugs issues. Long list of Checkstyle issues. Document the Java platform requirement clearly and early (or did I miss it?). Thank you again for preparing an RC, it is long overdue! Gary On Sun, Aug 9, 2015 at 8:55 PM, <[email protected]> wrote: > > The last BCEL release (5.2) occurred in February of 2006. It’s been nine > years since the last release and four years since the code was transferred > to commons. Over this time, java byte code has been enhanced with > additional opcodes and dynamic language support. Supporting these byte > code changes is the most significant feature of BCEL-6.0. > > BCEL 6.0 RC4 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/bcel (svn revision > 10111) > > Maven artifacts are here: > > https://repository.apache.org/content/repositories/orgapachecommons-1104/org/apache/commons/commons-bcel6/6.0/ > > Details of changes since 5.2 are in the release notes: > https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt > https://people.apache.org/~chas/bcel-6.0-RC4/changes-report.html > > I have tested this with JDK 1.7 using maven3. > > The tag is here: > http://svn.apache.org/repos/asf/commons/proper/bcel/tags/BCEL_6_0_RC4/ > (svn revision 1694950) > > Site: > https://people.apache.org/~chas/bcel-6.0-RC4/ > (note some *relative* links are broken - these should be OK once the > site is deployed) > > Clirr Report: > N/A > > RAT Report: > https://people.apache.org/~chas/bcel-6.0-RC4/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, i.e. after 1800 > GMT 12 August 2015 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > Chas > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
