+1 drop ant On Mon, Mar 21, 2016 at 5:06 PM Oliver Heger <oliver.he...@oliver-heger.de> wrote:
> Hi Benedikt, > > Am 21.03.2016 um 09:58 schrieb Benedikt Ritter: > > Hello Oliver, > > > > very nice artifacts, good work. > > > > - builds with java 6, 7 and 8 > > - site looks good > > - reports look good > > > > Only thing I found is: > > - build.xml and build.properties.sample are in the tag but not in the src > > archive. The ant build can probably be dropped (does it work anyway?). No > > blocker for me. > > > > +1 > > thanks for the review. > > You are right, the ant-related files should be part of the source > distribution. build.xml should be pretty up-to-date. However, > maintaining two different build files is a pain and error-prone. The > trend seems to be dropping the ant build. I would be in favor of this. > > Oliver > > > > > Benedikt > > > > Oliver Heger <oliver.he...@oliver-heger.de> schrieb am So., 20. März > 2016 > > um 22:42 Uhr: > > > >> Hi all, > >> > >> after a series of alpha and beta releases, I think we are now ready to > >> release the final 2.0 version of [configuration]. So this is the > >> corresponding release vote. > >> > >> Configuration 2.0 RC1 is available for review here: > >> https://dist.apache.org/repos/dist/dev/commons/configuration > >> (revision 12797) > >> > >> Maven artifacts are here: > >> > >> > https://repository.apache.org/content/repositories/orgapachecommons-1143 > >> > >> Details of changes since 1.10 and the previous beta version are in the > >> release notes: > >> > >> > >> > https://dist.apache.org/repos/dist/dev/commons/configuration/RELEASE-NOTES.txt > >> > >> > https://home.apache.org/~oheger/configuration-2.0-rc1/changes-report.html > >> > >> Here is the tag: > >> > >> > >> > http://svn.apache.org/repos/asf/commons/proper/configuration/tags/CONFIGURATION_2_0_RC1 > >> (revision 1735904) > >> > >> Site: > >> https://home.apache.org/~oheger/configuration-2.0-rc1/ > >> (note some links in the menu are not yet working) > >> > >> KEYS: > >> http://www.apache.org/dist/commons/KEYS > >> > >> Please review the release candidate and vote. > >> This vote will close no sooner than 72 hours from now, i.e. after 2200 > >> GMT 23-Mar 2016 > >> > >> [ ] +1 Release these artifacts > >> [ ] +0 OK, but... > >> [ ] -0 OK, but really should fix... > >> [ ] -1 I oppose this release because... > >> > >> Thanks! > >> Oliver > >> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
