+1

>From src zip: MD5, SHA1, ASC OK.
Also src tar gz: MD5, SHA1, ASC OK.

>From src zip: mvn clean site OK.

All reports OK except Checkstyle:

I assume the Checkstyle violations are not new compared to 1.3.1. I cannot
tell because our site is for 1.4-SNAPSHOT
https://commons.apache.org/proper/commons-fileupload/checkstyle.html. Not a
blocker.

TODO: Add a test code coverage report. Not a blocker.

TODO: Drop Ant build? Not a blocker.

Q: Do we really need a Gump file? Not a blocker.

Tested with:

Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
05:51:28-0800)
Maven home: E:\Java\apache-maven-3.0.5
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_91\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "dos"

Gary


On Mon, May 23, 2016 at 8:23 AM, Benedikt Ritter <brit...@apache.org> wrote:

> It has been a long time since the last release of Apache Commons
> FileUpload, so I'd like to release Apache Commons FileUpload 1.3.2 based on
> RC1.
>
> Apache Commons FileUpload 1.3.2 RC1 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/fileupload (rev 13750)
>
> Maven artifacts are here:
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-1173/commons-fileupload/commons-fileupload/1.3.2/
>
> These are the Maven artifacts and their hashes
>
> commons-fileupload-1.3.2-javadoc.jar
> (SHA1: 12bbb300a1b61e038defb1dee85e8302d6f1bbaa)
> commons-fileupload-1.3.2-sources.jar
> (SHA1: 23996750d5a80dc74dad55633c2a0f3db91462cb)
> commons-fileupload-1.3.2-test-sources.jar
> (SHA1: 2df285ad143910759a3763fcec0cd58e8525d881)
> commons-fileupload-1.3.2-tests.jar
> (SHA1: 310e3713308073a0392be30c129b55e872fe48f6)
> commons-fileupload-1.3.2,jar
> (SHA1: 5d7491ed6ebd02b6a8d2305f8e6b7fe5dbd95f72)
> commons-fileupload-1.3.2.pom
> (SHA1: a4c3e5d590c2e83bba42768c5b5fbef43219b5c4)
>
> Details of the change since 1.3.1 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/fileupload/RELEASE-NOTES.txt
>
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/changes-report.html
>
> I have tested this with:
>   JDK 1.6 and Maven 3.2.5
>   JDK 1.7 and Maven 3.3.9
>   JDK 1.8 and Maven 3.3.9
> Note that commons-fileupload should be JDK 1.5 compatible, but I don't have
> a JDK 1.5 installation on my MacBook. If someone could check the build with
> JDK 1.5, that would be great!
>
> The tag is here:
>
>
> https://svn.apache.org/repos/asf/commons/proper/fileupload/tags/FILEUPLOAD_1_3_2_RC1
>  (rev 1745203)
>
> Site:
>   http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/
> (note some *relative* links are broken and the 1.3.2 directories are not
> yet created - these will be OK once the site is deployed)
>
> Clirr Report (compared to 1.3):
>
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/clirr-report.html
> (note that the API additions have been introduced in 1.3.1 not in 1.3.2)
>
> RAT Report:
>
>
> http://home.apache.org/~britter/commons/fileupload-1.3.2-rc1/rat-report.html
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now,
> i.e. sometime after 17:30 CEST 26-May 2016
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] +0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thanks!
> Benedikt
>



-- 
E-Mail: garydgreg...@gmail.com | ggreg...@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Reply via email to