Am 03.06.2016 um 22:16 schrieb Gary Gregory: > On Jun 3, 2016 12:53 PM, "Oliver Heger" <oliver.he...@oliver-heger.de> > wrote: >> >> Build works fine with Java 1.6 on Windows 10. Artifacts and site look > good. >> >> The site cannot be built with Java 8, and the release notes are missing >> BEANUTILS-477, but this is not blocking. >> >> I ran the tests for [configuration] with the new jar and got a single >> test failure which seems to be caused by the change for BEANUTILS-474. >> The tests sets a property using the method setIOFactory() and assumes >> that the property name is iOFactory. However, now the name IOFactory >> (with capital I) is returned. Is this correct/desired? > > Yes, based on the description of the ticket that deals with the cap change > IIRC, on my phone now, I can check details later but I think this change is > indeed as desired. > > Maybe the test is >> just wrong, but in the worst case this change could break some >> configuration files. How should we handle this? > > The test should be adjusted IMO. > > A more conservative path would be to revert the change and roll a new RC > based on the desire for 100% behavior compatibility if that is what we want.
I also tend to agree that the test should be adapted. It is very unlikely that somebody declares an IOFactory in a configuration file. And most other properties should have uncritical names. So the risk to break something is pretty low. Oliver > > Gary > >> >> Oliver >> >> Am 03.06.2016 um 02:24 schrieb Gary Gregory: >>> Apache Commons BeanUtils 1.9.3 RC1 is available for review here: >>> >>> https://dist.apache.org/repos/dist/dev/commons/beanutils/ >>> (revision 13874) >>> >>> commons-beanutils-1.9.3-bin.tar.gz >>> (SHA1: 5c66783bb2bce21992cc3515a7b78f36f17c8709) >>> commons-beanutils-1.9.3-bin.zip >>> (SHA1: 3508ced3e244bc1583f6f4be119f50fe4fd162b3) >>> commons-beanutils-1.9.3-src.tar.gz >>> (SHA1: 51879c555ae045f2c09a24eb69a68b6af0544c06) >>> commons-beanutils-1.9.3-src.zip >>> (SHA1: 0a16325c44dfee1a29e1e6788115930acbb13313) >>> >>> Maven artifacts are here: >>> >>> > https://repository.apache.org/content/repositories/orgapachecommons-1176/commons-beanutils/commons-beanutils/1.9.3/ >>> >>> These are the artifacts and their hashes: >>> >>> commons-beanutils-1.9.3-test-sources.jar >>> (SHA1: 5365ebf268504d69941c21007a2c0a1334589e8f) >>> commons-beanutils-1.9.3-sources.jar >>> (SHA1: 53bae8809672897cb9954669775fb214623c6b89) >>> commons-beanutils-1.9.3.pom >>> (SHA1: dbedbbc25b2a981a7598f647100092ce5cb28a55) >>> commons-beanutils-1.9.3.jar >>> (SHA1: 15f7207f3ccfb6aa607eb93414723bf8a0c9297c) >>> commons-beanutils-1.9.3-javadoc.jar >>> (SHA1:71f2729e5b5bc5f969233c190c105607f55859bf) >>> commons-beanutils-1.9.3-tests.jar >>> (SHA1: 3c0a8818f23da165b6e825874c3287e1cbec403b) >>> >>> Details of changes since 1.9.2 are in the release notes: >>> >>> > https://dist.apache.org/repos/dist/dev/commons/beanutils/RELEASE-NOTES.txttxt >>> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/changes-report.html >>> >>> >>> The tag is here: >>> > https://svn.apache.org/repos/asf/commons/proper/beanutils/tags/beanutils-1.9.3-RC1/ >>> (revision 1745420) >>> >>> Site: >>> http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/ >>> >>> (some *relative* links are broken - these will be OK once the site >>> is deployed) >>> >>> Clirr Report (compared to 1.9.2): >>> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/clirr-report.html >>> >>> RAT Report: >>> > http://home.apache.org/~ggregory/beanutils-1.9.3-rc1/site/rat-report.html >>> >>> KEYS: >>> https://www.apache.org/dist/commons/KEYS >>> >>> Please review the release candidate and vote. >>> >>> This vote will close no sooner than 72 hours from now, i.e. sometime > after >>> 18:00 PST 5 June 2016 >>> >>> >>> [ ] +1 Release these artifacts >>> [ ] +0 OK, but... >>> [ ] -0 OK, but really should fix... >>> [ ] -1 I oppose this release because... >>> >>> Thanks! >>> Gary Gregory >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
