Thank Gary for pointing it out, The reason sounds good to me, and running tests didn't cost too much time, I think we can remove " -DskipTests "
Regards Dapeng -----Original Message----- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Tuesday, June 07, 2016 10:37 AM To: Commons Developers List Subject: [crypto] Instructions MUST mention running the tests Hi All: When I see instructions in BUILDING.txt like: Create binary distribution: $ mvn package -DskipTests I am worried! Why would you NOT want to run unit tests? Skipping tests from Maven is a hack when you know what you are doing. Like when I just ran the tests, all passed, and I changed something that is not Java source. IMO, we need better build instructions. I've added steps for RAT and Clirr, a must for any Maven component here. Thank you, Gary -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
