Hello Dapeng, first of all: Great work moving Crypto to Apache Commons and creating your first release candidate for the Apache Commons Project. I'm very happy to see this happening and I hope you and the other former Chimera developers are still happy with moving the code to Commons.
Here is my review of this RC: - Release notes look good. Minor nit: they don't mention the minimum required Java version. - BUILDING.txt is very descriptive, good work - Website looks good - signs and hashes are good I've tried the build with: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00) Maven home: /usr/local/Cellar/maven/3.3.9/libexec Java version: 1.7.0_79, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_79.jdk/Contents/Home/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac" I get an error: JceCipherTest.checkJceUnlimitedStrength:44 Testing requires support for an AES key length of 256, but the detected maximum key length is 128. This may indicate that the test environment is missing the JCE Unlimited Strength Jurisdiction Policy Files. I have installed the necessary files, but it doesn't work. I suspect that there's something wrong with my JDK installation. I've tried building with: Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m; support was removed in 8.0 Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00) Maven home: /usr/local/Cellar/maven/3.3.9/libexec Java version: 1.8.0_91, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/jre Default locale: de_DE, platform encoding: UTF-8 OS name: "mac os x", version: "10.11.6", arch: "x86_64", family: "mac" And it works perfectly fine. Since the build failure is probably related to my environment: +1 Regards, Benedikt Sun, Dapeng <dapeng....@intel.com> schrieb am Di., 26. Juli 2016 um 05:25 Uhr: > Hi all, > > > > Apache Commons CRYPTO was established at May 9, 2016, There are presently > numbers of resolved issues fix in CRYPTO. We also fix the legal issue. > > > > Apache Commons CRYPTO 1.0.0 is available for review here: > > https://dist.apache.org/repos/dist/dev/commons/crypto > > (rev 14538) > > > > The tag is here: > > > https://git-wip-us.apache.org/repos/asf?p=commons-crypto.git;a=tag;h=refs/tags/CRYPTO-1.0.0-RC1 > > (commit 782ca06a1f9a292756fbad9eb9841e685cd34af1) > > > > Maven artifacts: > > > > > https://repository.apache.org/content/repositories/orgapachecommons-1191/org/apache/commons/commons-crypto/1.0.0/ > > > > I've tested with Java 7 & 8 using Maven 3.0.5 on Mac OS 64bits/Linux > 64&32bits/Windows 64&32 bits > > > > Details of changes are in the release notes: > > https://dist.apache.org/repos/dist/dev/commons/crypto/RELEASE-NOTES.txt > > http://home.apache.org/~sdp/crypto-1.0.0-rc1/changes-report.html > > > > Site: > > http://home.apache.org/~sdp/crypto-1.0.0-rc1/ > > (note some links are broken, these will be OK once the site is deployed) > > > > Clirr Report: > > Not generating Clirr report as there is no previous version of the library > to compare against. > > > > RAT Report: > > http://home.apache.org/~sdp/crypto-1.0.0-rc1/rat-report.html > > > > KEYS: > > https://www.apache.org/dist/commons/KEYS > > > > Please review the release candidate and vote. This vote will close no > sooner than 72 hours from now, i.e. sometime after 13:00 CST 29-July 2016 > > > > [ ] +1 Release these artifacts > > [ ] +0 OK, but... > > [ ] -0 OK, but really should fix... > > [ ] -1 I oppose this release because... > > > > Thanks & Regards > > Dapeng > >
