I've created <https://issues.apache.org/jira/browse/DBCP-465>. Can we fix this and make a new release candidate, or is this release going to pass the vote technically?
On 1 August 2016 at 17:53, Matt Sicker <boa...@gmail.com> wrote: > It very well could be. The basic OSGi tests in log4j could work here as > this would have failed such a test. > > On 1 August 2016 at 16:13, Gary Gregory <garydgreg...@gmail.com> wrote: > >> On Mon, Aug 1, 2016 at 2:09 PM, Matt Sicker <boa...@gmail.com> wrote: >> >> > There's something wrong with the OSGi manifest. javax.transaction is >> > imported twice in the manifest and that causes an error at runtime. I >> need >> > to investigate further, but this could be a blocker. >> > >> >> Could this be added as a unit test using Equinox and/or Felix? >> >> Gary >> >> > >> > On 1 August 2016 at 14:55, Oliver Heger <oliver.he...@oliver-heger.de> >> > wrote: >> > >> > > Build works fine with Java 1.7 and 1.8 on Windows 10. Artifacts and >> site >> > > look good. >> > > >> > > +1, great work! >> > > >> > > Oliver >> > > >> > > Am 31.07.2016 um 00:15 schrieb Matt Sicker: >> > > > We have fixed quite aWe have fixed quite a few bugs and added some >> > > > significant enhancements since DBCP 2.1.1 was released, so I would >> like >> > > to >> > > > release DBCP 2.2. >> > > > >> > > > This is my first release on Apache Commons, so please take a close >> look >> > > at >> > > > everything as it's been almost two years since I've been an RM for >> any >> > > > Apache project. There is a known problem already that I committed >> some >> > > > things to trunk before making a release branch, so the current >> trunk >> > has >> > > > some 2.2 release notes and readme files already which may cause >> > confusion >> > > > until it's released. >> > > > >> > > > DBCP 2.2 RC1 is available for review here: >> > > > >> https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC1/ >> > > (svn >> > > > revision 14584) >> > > > >> > > > The tag is here: >> > > > >> > > >> https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_2_RC1/ >> > > > (svn revision 1754631) >> > > > N.B. the SVN revision is required because SVN tags are not >> > immutable. >> > > > >> > > > Maven artifacts are here: >> > > > >> > > > >> > > >> > >> https://repository.apache.org/content/repositories/orgapachecommons-1193/ >> > > > >> > > > These are the Maven artifacts and their hashes (sha256) >> > > > >> > > > 5fd62ab54872dda88ff0643fe9fe82be39125a0f7712537b3516fa6dcb2fec91 >> > > > commons-dbcp2-2.2.jar >> > > > c3983942c3aecd642f76631657789d09fbf63142d0f570fb32925fad65ba6a93 >> > > > commons-dbcp2-2.2-javadoc.jar >> > > > 6f5d2087b1198adefbfe2006a9225643c07c9244dc64686895acb2358aedf2d5 >> > > > commons-dbcp2-2.2-sources.jar >> > > > 610674620699b5012fdddddb593b465dce629757dbc1127d68147f0b864b7dd2 >> > > > commons-dbcp2-2.2-tests.jar >> > > > ad8341241fa105d26be9508142469881a016959c8d94d6b283cfe1c43d5b9768 >> > > > commons-dbcp2-2.2-test-sources.jar >> > > > >> > > > I have tested this with JDK 1.7 (IcedTea 2.6.6) (Parabola >> > GNU/Linux-libre >> > > > build 7.u101_2.6.6-1.parabola1-x86_64) and 1.8 (build >> 1.8.0_102-b14), >> > > using >> > > > Maven 3.3.9 >> > > > >> > > > Details of changes since 2.1.1 are in the release notes: >> > > > >> > > > >> > > >> > >> https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/DBCP_2_2_RC1/RELEASE-NOTES.txt >> > > > http://musigma.org/dbcp/changes-report.html >> > > > >> > > > Site: >> > > > http://musigma.org/dbcp/ >> > > > (note some *relative* links are broken and the 2.2 directories are >> > > > not yet created - these will be OK once the site is deployed) >> > > > (also note that I had to upload this to GitHub instead of >> > > home.apache.org >> > > > due to technical problems; see https://github.com/jvz/dbcp for >> source) >> > > > >> > > > Clirr Report (compared to 2.1.1): >> > > > http://musigma.org/dbcp/clirr-report.html >> > > > >> > > > Clirr report looks pretty uneventful. >> > > > >> > > > RAT Report: >> > > > http://musigma.org/dbcp/rat-report.html >> > > > >> > > > KEYS: >> > > > https://www.apache.org/dist/commons/KEYS >> > > > >> > > > Please review the release candidate and vote. >> > > > This vote will close no sooner that 72 hours from now, >> > > > i.e. 02-Aug-16 in the evening. >> > > > >> > > > [ ] +1 Release these artifacts >> > > > [ ] +0 OK, but... >> > > > [ ] -0 OK, but really should fix... >> > > > [ ] -1 I oppose this release because... >> > > > >> > > > Thanks! >> > > > >> > > > -- >> > > > Matt Sicker <boa...@gmail.com> >> > > > >> > > >> > > --------------------------------------------------------------------- >> > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> > > For additional commands, e-mail: dev-h...@commons.apache.org >> > > >> > > >> > >> > >> > -- >> > Matt Sicker <boa...@gmail.com> >> > >> >> >> >> -- >> E-Mail: garydgreg...@gmail.com | ggreg...@apache.org >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > Matt Sicker <boa...@gmail.com> > -- Matt Sicker <boa...@gmail.com>
