Yes, I'd like to make a decent integration test for this. This could have helped the original bugfix that caused this new bug, too. :)
On 9 August 2016 at 10:23, Gary Gregory <garydgreg...@gmail.com> wrote: > This is more than likely something all Commons components could benefit > from... I would be really nice to capture your testing in an integration > test we can run from Maven. > > We could put anything generic in a Commons OSGi component even if it only > has test code. > > Gary > > On Mon, Aug 8, 2016 at 10:17 AM, Matt Sicker <boa...@gmail.com> wrote: > > > Damn, I'm still having OSGi issues with this RC. I've reopened > > https://issues.apache.org/jira/browse/DBCP-454 to investigate. I may > need > > to cut an rc3, though. > > > > On 7 August 2016 at 14:03, Matt Sicker <boa...@gmail.com> wrote: > > > > > We have fixed quite a few bugs and added some significant enhancements > > > since DBCP 2.1.1 was released, so I would like to release DBCP 2.2. > > > > > > Changes since 2.2 rc1: > > > * Added a bug fix from jira that wasn't included in the release notes > as > > > it had the wrong fix version attached. > > > * Fixed DBCP-454. > > > * Fixed scm link to point to the future DBCP_2_2 tag instead of the > > > release candidate tag. > > > * Added link to 2.2 javadocs on sidebar. > > > * Various fumblings with subversion. > > > > > > DBCP 2.2 RC2 is available for review here: > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2 > > (svn > > > revision 14694) > > > > > > The tag is here: > > > https://svn.apache.org/repos/asf/commons/proper/dbcp/tags/ > > > DBCP_2_2_RC2/ (svn revision 1755453) > > > N.B. the SVN revision is required because SVN tags are not > immutable. > > > > > > Maven artifacts are here: > > > https://repository.apache.org/content/repositories/ > > > orgapachecommons-1196/ > > > > > > These are the Maven artifacts and their sha256 hashes > > > > > > 64a093b7fa2ca077b8f1cce5847308c0c89fed20fc33e499f559e00b7ba526aa > > > commons-dbcp2-2.2.jar > > > 22c3b706e8590f92688dc91399427daa3bbd35e3da0b31375d45877d2ca193f2 > > > commons-dbcp2-2.2-javadoc.jar > > > 5dfe8ead3d3626d76e37f19fe26555c1caeedc071e74cacab0693bdf41c33e08 > > > commons-dbcp2-2.2-sources.jar > > > 32c35b92a48f179ad9de8ee3d3a8acad4baf002a4878f03174adb0d486e8b98c > > > commons-dbcp2-2.2-tests.jar > > > 6333a2bca35bd127b364b8494b1eee69942fe00474af4fd2a33ec493aa9b1997 > > > commons-dbcp2-2.2-test-sources.jar > > > > > > I have tested this with JDK 1.7 (u111) and 1.8 (u102) using Maven > 3.3.9. > > > > > > Details of changes since 2.1.1 are in the release notes: > > > https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_ > > > 2_RC2/RELEASE-NOTES.txt > > > http://musigma.org/dbcp/changes-report.html > > > > > > Site (hosted on GitHub <https://github.com/jvz/dbcp>): > > > http://musigma.org/dbcp/ > > > (note some *relative* links are broken and the 2.2 directories are > > > not yet created - these will be OK once the site is deployed) > > > > > > Clirr Report (compared to 2.1.1): > > > http://musigma.org/dbcp/clirr-report.html > > > > > > RAT Report: > > > http://musigma.org/dbcp/rat-report.html > > > > > > KEYS: > > > https://www.apache.org/dist/commons/KEYS > > > > > > Please review the release candidate and vote. > > > This vote will close no sooner that 72 hours from now, > > > i.e. sometime after 10-Aug-2016 > > > > > > [ ] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > Thanks! > > > > > > -- > > > Matt Sicker <boa...@gmail.com> > > > > > > > > > > > -- > > Matt Sicker <boa...@gmail.com> > > > > > > -- > E-Mail: garydgreg...@gmail.com | ggreg...@apache.org > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <boa...@gmail.com>
