On Thu, Aug 18, 2016 at 12:38 AM, Gilles <gil...@harfang.homelinux.org>
wrote:
>
>> Artem,
>>>
>>> You have introduced spurious blank spaces.
>>>
>>>
>> Actually I've removed them.
>>
>
> Ah, OK. Sorry; I had the "diff" arguments in revers order.
>
> Anyways, when you do that, do it in a separate commit.
> We should avoid mixing formatting changes with contents change.
>
Yes, you are right.
>
>
>>
>>
>>
>>> You should perform
>>> $ git diff --check
>>>
>>> You committed a file ("checkstyle.xml") unrelated to the
>>> commit message...
>>>
>>>
>> My IDE by default removing trailing whitespaces. Will adjust my configs
>> to not doing this next time.
>>
>
> Removing spurious space is fine.
>
> But you should perhaps adjust the config to not automatically commit
> every changed file.
Already did it, will make sure next time I'm not committing unrelated
things.
Best regards,
Artem Barger.
