This sounds very similar to the previous attempt to do this that broke our tool Daikon. Please see https://issues.apache.org/jira/browse/BCEL-79 and make sure we're not doing this incorrectly again.
Unfortunately, I do not have the time right now to do a full review. If no one else volunteers, let me know and I'll see what I can do. Thanks, Mark > -----Original Message----- > From: Benedikt Ritter [mailto:brit...@apache.org] > Sent: Saturday, August 27, 2016 7:27 AM > To: Commons Developers List > Subject: [BCEL] Need advice on GitHub PR > > Hello everybody, > > we have this PR [1] which has been pending for a while. Now we only have one > comment left [2], which I can't really get my head around (probably due to > missing > experience with byte code generation and stuff :o) > > Does anybody have time to take a look? > > Best regards, > Benedikt > > [1] https://github.com/apache/commons-bcel/pull/10 > [2] https://github.com/apache/commons-bcel/pull/10#discussion_r75886503 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
