Github user kinow commented on a diff in the pull request:
https://github.com/apache/commons-compress/pull/20#discussion_r113178004
--- Diff:
src/main/java/org/apache/commons/compress/compressors/lzma/LZMACompressorInputStream.java
---
@@ -56,7 +56,7 @@ public LZMACompressorInputStream(final InputStream
inputStream)
in = new LZMAInputStream(inputStream,
MemoryLimit.getMemoryLimitInKb());
} catch (org.tukaani.xz.MemoryLimitException e) {
//convert to commons-compress exception
- throw new MemoryLimitException("exceeded calculated memory
limit", e);
+ throw new MemoryLimitException(e.getMemoryNeeded(),
e.getMemoryLimit());
--- End diff --
Sounds good. There are a few other places in this pull request where the
root exception is discarded too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
