I've submitted several such cleanups over the past couple of month, and for the most part, they've been well received.
I think the key here is to improve the codebase when possible but to leave room to deviate from IntelliJ's norms when there's a good reason to. Perhaps annotating such places with @SuppressWarning would be the best approach, to signal to future developers that the warning was considered, and we explicitly decided to suppress it (possibly with a comment in the code explaining why). On Wed, Jul 5, 2017 at 6:42 PM, Matt Sicker <boa...@gmail.com> wrote: > I like the idea myself at least, though I'm not sure if it conflicts with > any coding styleguides established. > > On 4 July 2017 at 18:18, Jonathan Bluett-Duncan <jbluettdun...@gmail.com> > wrote: > > > Hi all, > > > > I'm interested in going through commons-lang with IntelliJ IDEA and > > applying small refactorings to make the code base easier to read and/or > > more performant (and also make IntelliJ IDEA itself report less > warnings). > > > > Is this something that the [lang] team would find useful? > > > > Examples of refactorings that I could apply include: > > > > - Replace manual array-to-collection copy operations with > > `Collections.addAll()`. > > - Replace simple `String{Buffer,Builder}` usages with direct `String` > > concatenations or `String.format()`. > > - Simplifying boolean expressions like `obj instanceof CharRange == > > false` to `!(obj instanceof CharRange)`. > > > > > > Cheers, > > Jonathan > > > > > > -- > Matt Sicker <boa...@gmail.com> >