As far as I know the commit is only displayed as merged on git hub if it was
not altered in any way.
Forhttps://github.com/apache/commons-lang/pull/274 I appended "(
<https://github.com/apache/commons-lang/commit/a37d19eb45d76cd6ab4e2c8fa9fc156bf7be97db>closes
<https://github.com/apache/commons-lang/commit/a37d19eb45d76cd6ab4e2c8fa9fc156bf7be97db> #274 <https://github.com/apache/commons-lang/pull/274>)
<https://github.com/apache/commons-lang/commit/a37d19eb45d76cd6ab4e2c8fa9fc156bf7be97db>" to the commit message and that changes the hash.
Cheers,
Pascal
Am 14.07.2017 um 22:44 schrieb Amey Jadiye:
well It's still confusing...
Example.
https://github.com/apache/commons-lang/pull/270
Here in #270 asfgit merged the PR
While
https://github.com/apache/commons-lang/pull/274
Here in #274 asfgit closed PR.
Regards,
Amey
On Sat, Jul 15, 2017, 2:07 AM Gary Gregory <garydgreg...@gmail.com> wrote:
If a Git commit comment says "Closes #<PR#>" like "Closes #29", PR #29 will
be closed. I forget to do that sometimes.
Gary
On Fri, Jul 14, 2017 at 1:29 PM, Amey Jadiye <ameyjad...@gmail.com> wrote:
I wonder is there different process for accepting PR in text and lang ?
Whenever I open PR for text ,after acceptance it says "asfgit merged
branch" and it automatically shows pr status as #merged on github while
for
lang after merging my code PR stays open and I have to manually close it?
Regards,
Amey
---------- Forwarded message ---------
From: garydgregory <g...@git.apache.org>
Date: Sat, Jul 15, 2017, 12:21 AM
Subject: [GitHub] commons-lang issue #277: run maven defaultGoal from
Travis
To: <iss...@commons.apache.org>
Github user garydgregory commented on the issue:
https://github.com/apache/commons-lang/pull/277
Patch applied. Thank you!
---
If your project is set up for it, you can reply to this email and have
your
reply appear on GitHub as well. If your project does not have this
feature
enabled and wishes so, or if the feature is enabled but not working,
please
contact infrastructure at infrastruct...@apache.org or file a JIRA
ticket
with INFRA.
---
