Github user jbduncan commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/56#discussion_r127854827
--- Diff:
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -295,41 +295,42 @@ public void testEqualsHashcode() {
ExtendedMessageFormat other = null;
// Same object
- assertTrue("same, equals()", emf.equals(emf));
+ assertTrue("same, equals()", emf.equals(emf));
assertTrue("same, hashcode()", emf.hashCode() == emf.hashCode());
assertFalse("null, equals", emf.equals(null));
// Equal Object
other = new ExtendedMessageFormat(pattern, Locale.US, fmtRegistry);
- assertTrue("equal, equals()", emf.equals(other));
+ assertTrue("equal, equals()", emf.equals(other));
assertTrue("equal, hashcode()", emf.hashCode() ==
other.hashCode());
// Different Class
other = new OtherExtendedMessageFormat(pattern, Locale.US,
fmtRegistry);
- assertFalse("class, equals()", emf.equals(other));
+ assertFalse("class, equals()", emf.equals(other));
assertTrue("class, hashcode()", emf.hashCode() ==
other.hashCode()); // same hashcode
// Different pattern
other = new ExtendedMessageFormat("X" + pattern, Locale.US,
fmtRegistry);
- assertFalse("pattern, equals()", emf.equals(other));
+ assertFalse("pattern, equals()", emf.equals(other));
assertFalse("pattern, hashcode()", emf.hashCode() ==
other.hashCode());
// Different registry
other = new ExtendedMessageFormat(pattern, Locale.US,
otherRegitry);
- assertFalse("registry, equals()", emf.equals(other));
+ assertFalse("registry, equals()", emf.equals(other));
assertFalse("registry, hashcode()", emf.hashCode() ==
other.hashCode());
// Different Locale
other = new ExtendedMessageFormat(pattern, Locale.FRANCE,
fmtRegistry);
- assertFalse("locale, equals()", emf.equals(other));
+ assertFalse("locale, equals()", emf.equals(other));
assertTrue("locale, hashcode()", emf.hashCode() ==
other.hashCode()); // same hashcode
}
/**
* Test a built in format for the specified Locales, plus
<code>null</code> Locale.
+ *
* @param pattern MessageFormat pattern
- * @param args MessageFormat arguments
+ * @param args MessageFormat arguments
--- End diff --
I think this line was fine before. Please consider reverting it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
