Hello. I am not sure about changing that. It looks to me like most of the VFS code uses opening braces on new lines. I actually agree with that style.
I would also accept to change it, but then completely. In fact the checkstyle template specifies curly = nl https://github.com/apache/commons-vfs/blob/trunk/checkstyle.properties#L17 Gruss Bernd -- http://bernd.eckenfels.net _____________________________ From: ggreg...@apache.org<mailto:ggreg...@apache.org> Sent: Donnerstag, Juli 20, 2017 1:56 AM Subject: svn commit: r1802440 - /commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java To: <comm...@commons.apache.org<mailto:comm...@commons.apache.org>> Author: ggregory Date: Wed Jul 19 23:56:13 2017 New Revision: 1802440 URL: http://svn.apache.org/viewvc?rev=1802440&view=rev Log: Format for more standard brace usage. Modified: commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java Modified: commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java?rev=1802440&r1=1802439&r2=1802440&view=diff ============================================================================== --- commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java (original) +++ commons/proper/vfs/trunk/core/src/test/java/org/apache/commons/vfs2/provider/jar/test/JarAttributesTestCase.java Wed Jul 19 23:56:13 2017 @@ -30,19 +30,16 @@ import org.junit.Test; * * @version $Id$ */ -public class JarAttributesTestCase -{ - private void printAttributes(final Map<String, Object> attributes) - { - for (final Map.Entry<String, Object> e : attributes.entrySet()) - { +public class JarAttributesTestCase { + + private void printAttributes(final Map<String, Object> attributes) { + for (final Map.Entry<String, Object> e : attributes.entrySet()) { System.out.println("Key: " + e.getKey() + ", Value: " + e.getValue()); } } @Test - public void testAttributes() throws Exception - { + public void testAttributes() throws Exception { final FileObject file = JarProviderTestCase.getTestJar(VFS.getManager(), "test.jar"); final Map<String, Object> attributes = file.getContent().getAttributes(); @@ -52,8 +49,7 @@ public class JarAttributesTestCase } @Test - public void testNestedAttributes() throws Exception - { + public void testNestedAttributes() throws Exception { final FileObject nested = JarProviderTestCase.getTestJar(VFS.getManager(), "nested.jar"); final FileObject file = nested.resolveFile("test.jar");
