Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/56#discussion_r128595517
  
    --- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
    @@ -416,6 +416,81 @@ public void testSetFormatsByArgumentIndex() {
             emf.setFormatsByArgumentIndex(new Format[]{new LowerCaseFormat(), 
new UpperCaseFormat()});
         }
     
    +    @Test
    +    public void 
testFailsToCreateExtendedMessageFormatTakingThreeArgumentsThrowsIllegalArgumentExceptionOne()
 {
    +        Map<String, FormatFactory> map = new HashMap<String, 
FormatFactory>();
    +        ExtendedMessageFormat extendedMessageFormat = null;
    --- End diff --
    
    No need to create a variable if it is not used. This will produce unused 
variable warnings in IDEs etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to