+1 BUT:
Branding: The RELEASE-NOTES.txt file should start with "Apache Commons Email Package" instead of "Commons Email Package". I would do away with the "Package" suffix, we just don't use that, if anything we say "Component" since the Apache Commons Projects is made up of Components. Building from the src zip: ASC, MD5, and SHA-1 OK. CLIRR check OK RAT check fails with: Unapproved licenses: src/test/resources/eml/attachment-only.eml src/test/resources/eml/html-attachment-content-disposition.eml src/test/resources/eml/html-attachment-encoded-filename.eml src/test/resources/eml/html-attachment.eml src/test/resources/eml/multipart-report.eml src/test/resources/eml/multipart-text-attachment-only.eml src/test/resources/eml/multipart-text-attachment.eml src/test/resources/eml/outofmemory-no-header-seperation.eml src/test/resources/eml/simple-reply.eml src/test/resources/eml/simple.eml Either these should be licensed with a header in each file or the files should be excluded from the RAT check. Built with: Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; 2017-04-03T12:39:06-07:00) Maven home: C:\Java\apache-maven-3.5.0\bin\.. Java version: 1.8.0_144, vendor: Oracle Corporation Java home: C:\Program Files\Java\jdk1.8.0_144\jre Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On Sat, Jul 29, 2017 at 7:24 AM, Stefan Bodewig <bode...@apache.org> wrote: > We have fixed quite a few bugs and added some significant enhancements > since Email 1.4 was released, so I would like to release Email 1.5. > > Email 1.5 RC1 is available for review here: > https://dist.apache.org/repos/dist/dev/commons/email/ > (svn revision 20667) > > The tag is here: > http://svn.apache.org/repos/asf/commons/proper/email/tags/ > EMAIL_1_5_RC1/ > (svn revision 1803366) > N.B. the SVN revision is required because SVN tags are not immutable. > > Maven artifacts are here: > https://repository.apache.org/content/repositories/ > orgapachecommons-1255/org/apache/commons/commons-email/1.5/ > > These are the Maven artifacts and their SHA1 hashes > > e8e677c6362eba14ff3c476ba63ccb83132dbd52 commons-email-1.5.jar > 6ccc8b44cb666b849b71ecc6fa32549a6461c099 commons-email-1.5-javadoc.jar > 09d31911480b5148275d8a26c60e355bbcbe9ae3 commons-email-1.5.pom > dbe951d1b89eb9472b4b2c8f618b8bc9783b6623 commons-email-1.5-sources.jar > 15afde52264e316438802b5bd05d34bc424bf659 commons-email-1.5-tests.jar > e157492dfd776839387a6ce4af0d191e0a92a534 commons-email-1.5-test- > sources.jar > > I have tested this with JDK 8 using Maven 3.0.5. > > As usual when I cut a release the site is not the one I'll publish > once the vote has succeeded. I'll recreate the site once the release > date is known. > > I've already copied the javadocs for 1.4 so > http://commons.apache.org/proper/commons-email/javadocs/api-1.4/index.html > already is available. The javadoc links and download page certainly > don't work in the staging site. > > Details of changes since 1.4 are in the release notes: > https://dist.apache.org/repos/dist/dev/commons/email/RELEASE-NOTES.txt > https://stefan.samaflost.de/staging/commons-email-1.5/ > changes-report.html > > Site: > https://stefan.samaflost.de/staging/commons-email-1.5/ > > Clirr Report (compared to 1.4): > https://stefan.samaflost.de/staging/commons-email-1.5/ > clirr-report.html > > RAT Report: > https://stefan.samaflost.de/staging/commons-email-1.5/rat-report.html > > KEYS: > https://www.apache.org/dist/commons/KEYS > > Please review the release candidate and vote. > This vote will close no sooner that 72 hours from now, > i.e. sometime after 14:30 UTC 1-Aug 2017 > > [ ] +1 Release these artifacts > [ ] +0 OK, but... > [ ] -0 OK, but really should fix... > [ ] -1 I oppose this release because... > > Thanks! > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
