already there:
https://github.com/apache/commons-lang/commit/a2dce32cdab108e7e281dfc27dd0a394e1419ce1
https://github.com/apache/commons-lang/commit/fdf05fa29babe21e64f9a5b268dc8406d449d4f1
Am 08.09.2017 um 19:01 schrieb Gary Gregory:
Unit test SVP! ; -)
Gary
On Sep 8, 2017 10:26, <[email protected]> wrote:
Repository: commons-lang
Updated Branches:
refs/heads/master d6ad3f015 -> a2dce32cd
LANG-1349: EqualsBuilder#isRegistered: swappedPair construction bug
(closes #282)
SwappedPair constructed as Pair.of(rhs,lhs)
Project: http://git-wip-us.apache.org/repos/asf/commons-lang/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-lang/commit/
3e08af57
Tree: http://git-wip-us.apache.org/repos/asf/commons-lang/tree/3e08af57
Diff: http://git-wip-us.apache.org/repos/asf/commons-lang/diff/3e08af57
Branch: refs/heads/master
Commit: 3e08af573f8b50da5202f55df62c925f88a47f3d
Parents: d6ad3f0
Author: namannigam <[email protected]>
Authored: Thu Aug 10 08:45:27 2017 +0530
Committer: pascalschumacher <[email protected]>
Committed: Fri Sep 8 18:19:04 2017 +0200
----------------------------------------------------------------------
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-lang/blob/
3e08af57/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
b/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
index 4e24bc5..d2cf7c7 100644
--- a/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
+++ b/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
@@ -157,7 +157,7 @@ public class EqualsBuilder implements Builder<Boolean>
{
static boolean isRegistered(final Object lhs, final Object rhs) {
final Set<Pair<IDKey, IDKey>> registry = getRegistry();
final Pair<IDKey, IDKey> pair = getRegisterPair(lhs, rhs);
- final Pair<IDKey, IDKey> swappedPair = Pair.of(pair.getLeft(),
pair.getRight());
+ final Pair<IDKey, IDKey> swappedPair = Pair.of(pair.getRight(),
pair.getLeft());
return registry != null
&& (registry.contains(pair) ||
registry.contains(swappedPair));
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
