Its already there [1] and fails if something is not correct in *main* but I
guess it doesn't check anything for test resources and test java files.
thats why build was passing till date.


[1]. https://github.com/apache/commons-text/blob/master/pom.xml

Regards,
Amey

On Fri, Sep 22, 2017 at 10:58 PM, Gary Gregory <garydgreg...@gmail.com>
wrote:

> Hm, I guess we could add 'apache-rat:check' and 'clirr:check' to the Travis
> and Jenkins builds.
>
> Gary
>
> On Fri, Sep 22, 2017 at 11:26 AM, Gary Gregory <garydgreg...@gmail.com>
> wrote:
>
> > Good catch and thank you.
> >
> > I wish we could set up Maven to run the RAT check and fail a local build
> > if a header is missing.
> >
> > Gary
> >
> >
> > On Fri, Sep 22, 2017 at 11:24 AM, <chtom...@apache.org> wrote:
> >
> >> Repository: commons-text
> >> Updated Branches:
> >>   refs/heads/master 3292f74df -> 8cdbbd34b
> >>
> >>
> >> license header
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/commons-text/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/commons-text/commit/8
> >> cdbbd34
> >> Tree: http://git-wip-us.apache.org/repos/asf/commons-text/tree/8cdbbd34
> >> Diff: http://git-wip-us.apache.org/repos/asf/commons-text/diff/8cdbbd34
> >>
> >> Branch: refs/heads/master
> >> Commit: 8cdbbd34be793c828fb2000a3d75661aacae7dfc
> >> Parents: 3292f74
> >> Author: Rob Tompkins <chtom...@gmail.com>
> >> Authored: Fri Sep 22 13:24:00 2017 -0400
> >> Committer: Rob Tompkins <chtom...@gmail.com>
> >> Committed: Fri Sep 22 13:24:00 2017 -0400
> >>
> >> ----------------------------------------------------------------------
> >>  .../resources/testResourceBundleLookup.properties    | 15
> >> +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >> ----------------------------------------------------------------------
> >>
> >>
> >> http://git-wip-us.apache.org/repos/asf/commons-text/blob/8cd
> >> bbd34/src/test/resources/testResourceBundleLookup.properties
> >> ----------------------------------------------------------------------
> >> diff --git a/src/test/resources/testResourceBundleLookup.properties
> >> b/src/test/resources/testResourceBundleLookup.properties
> >> index f1394e7..ea39746 100644
> >> --- a/src/test/resources/testResourceBundleLookup.properties
> >> +++ b/src/test/resources/testResourceBundleLookup.properties
> >> @@ -1,2 +1,17 @@
> >> +# Licensed to the Apache Software Foundation (ASF) under one or more
> >> +# contributor license agreements.  See the NOTICE file distributed with
> >> +# this work for additional information regarding copyright ownership.
> >> +# The ASF licenses this file to You under the Apache License, Version
> 2.0
> >> +# (the "License"); you may not use this file except in compliance with
> >> +# the License.  You may obtain a copy of the License at
> >> +#
> >> +#      http://www.apache.org/licenses/LICENSE-2.0
> >> +#
> >> +# Unless required by applicable law or agreed to in writing, software
> >> +# distributed under the License is distributed on an "AS IS" BASIS,
> >> +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> >> implied.
> >> +# See the License for the specific language governing permissions and
> >> +# limitations under the License.
> >> +
> >>  key = value
> >>  number = 2
> >>
> >>
> >
>



-- 

---------------------------------------------------------------------

To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

For additional commands, e-mail: dev-h...@commons.apache.org

Reply via email to