I usually keep the practice of running just `mvn` (which indeed run <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc</defaultGoal>) and if that's fine my submitted PR is always and 100% looks green.
Regards, Amey On Sat, Sep 23, 2017 at 9:06 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > Amazing what happens when I actually run the Checkstyle plugin myself ;-) > > Gary > > On Sat, Sep 23, 2017 at 9:34 AM, Pascal Schumacher < > pascalschumac...@gmx.net > > wrote: > > > Thanks! :) > > > > Am 23.09.2017 um 16:13 schrieb Gary Gregory: > > > >> Back to green! :-) https://travis-ci.org/apache/commons-text > >> > >> Gary > >> > >> On Sat, Sep 23, 2017 at 2:15 AM, Pascal Schumacher < > >> pascalschumac...@gmx.net > >> > >>> wrote: > >>> Thank you very much. Sadly there are still two violations: > >>> > >>> [INFO] There are 2 checkstyle errors. > >>> [ERROR] StrLookup.java[179] (design) FinalClass: Class > >>> ResourceBundleLookup should be declared as final. > >>> [ERROR] StrLookup.java[181:9] (javadoc) JavadocVariable: Missing a > >>> Javadoc > >>> comment. > >>> > >>> see: https://travis-ci.org/apache/commons-text/jobs/278794812 > >>> > >>> Am 22.09.2017 um 23:50 schrieb Gary Gregory: > >>> > >>> Fixed in git master. > >>>> > >>>> Gary > >>>> > >>>> On Fri, Sep 22, 2017 at 3:35 PM, Pascal Schumacher < > >>>> notificati...@github.com > >>>> > >>>> wrote: > >>>>> Builds on travis fail: > >>>>> > >>>>> [INFO] There are 6 checkstyle errors. > >>>>> [ERROR] StrLookup.java[119] (regexp) RegexpSingleline: Line has > >>>>> trailing > >>>>> spaces. > >>>>> [ERROR] StrLookup.java[125] (regexp) RegexpSingleline: Line has > >>>>> trailing > >>>>> spaces. > >>>>> [ERROR] StrLookup.java[181:9] (javadoc) JavadocVariable: Missing a > >>>>> Javadoc comment. > >>>>> [ERROR] StrLookup.java[183:9] (javadoc) JavadocMethod: Missing a > >>>>> Javadoc > >>>>> comment. > >>>>> [ERROR] StrLookup.java[194] (regexp) RegexpSingleline: Line has > >>>>> trailing > >>>>> spaces. > >>>>> [ERROR] StrLookup.java[199] (regexp) RegexpSingleline: Line has > >>>>> trailing > >>>>> spaces. > >>>>> > >>>>> see e.g.: https://travis-ci.org/apache/commons-text/jobs/278728858 > >>>>> > >>>>> — > >>>>> You are receiving this because you authored the thread. > >>>>> Reply to this email directly, view it on GitHub > >>>>> <https://github.com/apache/commons-text/commit/0b061698f7b8d > >>>>> c0665804fadcfb6f9f37048efee#commitcomment-24498832>, > >>>>> or mute the thread > >>>>> <https://github.com/notifications/unsubscribe-auth/ABIfNyqCj > >>>>> e4hkCkwblS9o6g2rL4hJM8Dks5slCgagaJpZM4PhRMH> > >>>>> . > >>>>> > >>>>> > >>>>> ------------------------------------------------------------ > --------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >>> > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > -- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
