No worries Pascal, it was good experience to change core logic of RandomStringUtils, also I'm free to pickup something else now ;-)
Regards, Amey On Mon, Oct 2, 2017, 3:49 PM Pascal Schumacher <pascalschumac...@gmx.net> wrote: > Sorry about wasting your work porting RandomStringUtils to commons-text. :( > > Sorry, > Pascal > > Am 29.09.2017 um 17:18 schrieb Amey Jadiye: > > Okey, no problem folks. I'm going to close my PR. also we might need to > > release lang-3.6.1 for undoing deprecation of RandomStringUtils if > > lang-3.7 is far. > > > > Regards, > > Amey > > > > On Fri, Sep 29, 2017 at 1:41 PM, Pascal Schumacher < > pascalschumac...@gmx.net > >> wrote: > >> After thinking more about it, I came the conclusion that > RandomStringUtils > >> fits into [lang], so I'm for option (b). > >> > >> Cheers, > >> Pascal > >> > >> > >> Am 28.09.2017 um 23:26 schrieb Rob Tompkins: > >> > >>> Options: > >>> > >>> (a) leave RandomStringUtils deprecated in [lang] and pull in Amey’s > pull > >>> request moving it into [text]. > >>> (b) undeprecate it in [lang]. > >>> > >>> The question is where should it reside? Does it fit as a general java > >>> Lang extension or is it more focused on text? > >>> > >>> I’m in the middle here. Note also that we had some users ask why it had > >>> been deprecated with no alternative. > >>> > >>> Amey - keep me honest here. I don’t want to overlook anything. > >>> > >>> -Rob > >>> > >>> On Sep 28, 2017, at 5:13 PM, Gary Gregory <garydgreg...@gmail.com> > wrote: > >>>> Can someone summarize what our options are here please? I'd rather > see it > >>>> fresh than chasing links in mailing list archives and try to un-nest > all > >>>> the nesting... ;-) > >>>> > >>>> Gary > >>>> > >>>> > >>>> > >>>> On Wed, Sep 27, 2017 at 1:01 PM, Rob Tompkins < > notificati...@github.com> > >>>> wrote: > >>>> > >>>> As I'm pulling this in this crosses my mind: > >>>>> Wait I'm curious here. Weren't folks leaning towards keeping > >>>>> RandomStringUtils in [lang]? > >>>>> > >>>>> The thread in question is this one: http://markmail.org/message/ > >>>>> 5tblwhldrwsbfdym > >>>>> > >>>>> It feels like @britter <https://github.com/britter>, > @PascalSchumacher > >>>>> <https://github.com/pascalschumacher>, and @garydgregory > >>>>> <https://github.com/garydgregory> were all leaning towards the > [lang] > >>>>> option. If that's the case we should probably go with that. > >>>>> > >>>>> — > >>>>> You are receiving this because you were mentioned. > >>>>> Reply to this email directly, view it on GitHub > >>>>> < > https://github.com/apache/commons-text/pull/62#issuecomment-332622968 > >>>>>> , > >>>>> or mute the thread > >>>>> <https://github.com/notifications/unsubscribe-auth/ABIfN0WS8 > >>>>> OJew2JaosTy8DEkFh8bqjU8ks5smpuVgaJpZM4PO83B> > >>>>> . > >>>>> > >>>>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >>> For additional commands, e-mail: dev-h...@commons.apache.org > >>> > >>> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > >> For additional commands, e-mail: dev-h...@commons.apache.org > >> > >> > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
