Due to the -1 VOTE from Benedikt, I am canceling this VOTE and will roll out RC2 ASAP.
Gary On Sun, Oct 1, 2017 at 8:08 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > I also had not considered building on Java 9 since Java 9 has made such a > mess with backward compatibility and a lot of Maven plugins fail on Java 9. > > Gary > > On Oct 1, 2017 04:12, "Benedikt Ritter" <brit...@apache.org> wrote: > >> Hello Gary, >> >> - signatures are good >> - Release notes look good >> - Website looks good >> >> With Java 7 and Java 8 I get these test failures: >> >> Results : >> >> Failed tests: >> ZipFileObjectTestCase.testReadingFilesInZipFile:98->readAndAssert:61 >> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7c0000gn/T/ >> ZipFileObjectTestCase7763728418042728238 <(804)%20272-8238> >> .zip!/read-xml-tests/file1.xml expected:<..." encoding="UTF-8"?>[ >> <Root1>foo1</Root1>] >> > but was:<..." encoding="UTF-8"?>[ >> ]Root1>foo1</Root1> >> > >> >> ZipFileObjectTestCase.testReadingOneAfterClosingAnotherFile:133->readAndAssert:61 >> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7c0000gn/T/ >> ZipFileObjectTestCase3559195487083894265 <(708)%20389-4265> >> .zip!/read-xml-tests/file1.xml expected:<..." encoding="UTF-8"?>[ >> <Root1>foo1</Root1>] >> > but was:<..." encoding="UTF-8"?>[ >> ]Root1>foo1</Root1> >> > >> ZipFileObjectTestCase.testReadingOneAfterClosingAnotherStrea >> m:155->resolveReadAssert:110->readAndAssert:61 >> zip:file:///var/folders/r3/mg882fyn5553f6wdhfb_6m7c0000gn/T/ >> ZipFileObjectTestCase1120083930847510889.zip!/read-xml-tests/file2.xml >> expected:<..." encoding="UTF-8"?>[ >> <Root2>foo2</Root2>] >> > but was:<..." encoding="UTF-8"?>[ >> ]Root2>foo2</Root2> >> > >> >> Tests run: 2341, Failures: 3, Errors: 0, Skipped: 4 >> >> On Java 9 I get four test errors in addition: >> >> Tests in error: >> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testLo >> adClass(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests) >> Run 1: PASS >> Run 2: PASS >> Run 3: PASS >> Run 4: PASS >> Run 5: PASS >> Run 6: >> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61 >> » ClassNotFound >> Run 7: >> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testLoadClass:61 >> » ClassNotFound >> Run 8: PASS >> Run 9: PASS >> Run 10: PASS >> Run 11: PASS >> Run 12: PASS >> Run 13: PASS >> Run 14: PASS >> Run 15: PASS >> Run 16: PASS >> Run 17: PASS >> Run 18: PASS >> Run 19: PASS >> Run 20: PASS >> Run 21: PASS >> Run 22: PASS >> Run 23: PASS >> Run 24: PASS >> Run 25: PASS >> >> org.apache.commons.vfs2.impl.test.VfsClassLoaderTests.testSe >> aling(org.apache.commons.vfs2.impl.test.VfsClassLoaderTests) >> Run 1: PASS >> Run 2: PASS >> Run 3: PASS >> Run 4: PASS >> Run 5: PASS >> Run 6: >> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88 >> » ClassNotFound >> Run 7: >> VfsClassLoaderTests>AbstractProviderTestCase.runTest:190->testSealing:88 >> » ClassNotFound >> Run 8: PASS >> Run 9: PASS >> Run 10: PASS >> Run 11: PASS >> Run 12: PASS >> Run 13: PASS >> Run 14: PASS >> Run 15: PASS >> Run 16: PASS >> Run 17: PASS >> Run 18: PASS >> Run 19: PASS >> Run 20: PASS >> Run 21: PASS >> Run 22: PASS >> Run 23: PASS >> Run 24: PASS >> Run 25: PASS >> >> org.apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderT >> est.org.apache.commons.vfs2.provider.hdfs.test.HdfsFileProviderTest >> Run 1: HdfsFileProviderTest.setUp:91 » ExceptionInInitializer >> Run 2: HdfsFileProviderTest.tearDown:135 NullPointer >> >> >> HdfsFileProviderTestCase$HdfsProviderTestSuite>AbstractTestSuite.run:137->setUp:98 >> » NoClassDefFound >> >> I building with: >> >> ~ > mvn -version >> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option >> MaxPermSize=128m; support was removed in 8.0 >> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; >> 2017-04-03T21:39:06+02:00) >> Maven home: /usr/local/Cellar/maven/3.5.0/libexec >> Java version: 1.8.0_144, vendor: Oracle Corporation >> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/ >> Home/jre >> Default locale: de_DE, platform encoding: UTF-8 >> OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" >> >> So I’m -1 on this release. >> >> Benedikt >> >> > Am 23.09.2017 um 18:43 schrieb Gary Gregory <ggreg...@apache.org>: >> > >> > We have fixed quite a few bugs and added some significant enhancements >> > since Apache Commons VFS 2.1 was released, so I would like to release >> > Apache Commons VFS 2.2. >> > >> > Apache Commons VFS 2.2 RC1 is available for review here: >> > https://dist.apache.org/repos/dist/dev/commons/vfs/ (svn revision >> 21925) >> > Get it: svn co https://dist.apache.org/repos/dist/dev/commons/vfs/ >> > >> > The tag is here: >> > >> > https://svn.apache.org/repos/asf/commons/proper/vfs/tags/com >> mons-vfs2-project-2.2-rc1/ >> > (svn revision 1809435) >> > N.B. the SVN revision is required because SVN tags are not immutable. >> > Get it: svn co >> > https://svn.apache.org/repos/asf/commons/proper/vfs/tags/com >> mons-vfs2-project-2.2-rc1/ >> > >> > Maven artifacts are here: >> > >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1268/content/org/apache/commons/commons-vfs2- >> distribution/2.2/ >> > >> > These are the artifacts and their SHA1 hashes: >> > >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-src.tar.gz >> > (SHA1: 212a069b5b1534686b68fe35a6984920d9413fde) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-bin.zip.asc >> > (SHA1: aac456496d4af37a1d1912b8348b4701cf337c85) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2.pom >> > (SHA1: d8053a146c0d7e4b9cf649e8d6a0aff680dc3946) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-src.zip.asc >> > (SHA1: dbdddf332fc7929672c3cf5211d97aaafb5f4aa2) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-bin.zip >> > (SHA1: d3021e90433d666715ffbef729036af1514e1fad) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-bin.tar.gz >> > (SHA1: 6c363670be91fbacdbc2d67012952f30e56001c2) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2.pom.asc >> > (SHA1: 0ceb2511d213875ec5f99d471075c5dc700282c4) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-src.tar.gz.asc >> > (SHA1: 54bcff53b916a9285926e9df20874d69a10325a9) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-src.zip >> > (SHA1: 7b99183a0e7c57d67b857c5a8ad57a1fdb126047) >> > /org/apache/commons/commons-vfs2-distribution/2.2/commons-vf >> s2-distribution-2.2-bin.tar.gz.asc >> > (SHA1: 7061382cf7e04adf78b24972ccd6698cc374cc16) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar.asc >> > (SHA1: dcba69041d5c882598655f05db26a4742885a85b) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-test-sources.jar >> > (SHA1: a36920f558b04a941d87a1efde85bd9d4559c2c3) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar.asc >> > (SHA1: fc31bf4504414da6d2b22aaaa90314fac060335a) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar.asc >> > (SHA1: 2b9ff24d85e9ead07add09f976211d594dd1c3e5) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom.asc >> > (SHA1: 2dd6bee343974fccf75f2ccb406827b996da7ddc) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.pom >> > (SHA1: 8ddc26fc8729a7f3a6a1c642e4069b58d3a5ec04) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-test- >> sources.jar.asc >> > (SHA1: cbc27431defc0c34c7303d7f6ba0e367feea19cf) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar.asc >> > (SHA1: 29d1e2c30e404ea5cf9d7e5544479e04a78314cb) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2.jar >> > (SHA1: 18f974ce4c6a978eca23f769af8c6898d9694424) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-sources.jar >> > (SHA1: 8694cec165e6ef6c796a8bfae2ef565f32a5b82c) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-javadoc.jar >> > (SHA1: 972e8bd4c3d4e3b5fbd2033aa4d80013eb1ec694) >> > /org/apache/commons/commons-vfs2/2.2/commons-vfs2-2.2-tests.jar >> > (SHA1: 5e238e41b28c10f2ca21dc56f5bca471cd892ebd) >> > /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2-pr >> oject-2.2-site.xml >> > (SHA1: 45db714de819ec12adc528479bf9a4a2e15ba323) >> > /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2-pr >> oject-2.2.pom >> > (SHA1: dece2db6026f36f9dbbad8668cfb1fca867fbb64) >> > /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2-pr >> oject-2.2.pom.asc >> > (SHA1: d2998c437160b336480b7faed21256eed16ffc95) >> > /org/apache/commons/commons-vfs2-project/2.2/commons-vfs2-pr >> oject-2.2-site.xml.asc >> > (SHA1: 1c3ca11863fa8a12356c19fd35602aad51cc9052) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2-sources.jar.asc >> > (SHA1: dcbedc0faceff7b5694352b28286fb706e30712f) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2-sources.jar >> > (SHA1: 1744c6a0eac0c79a776e1d321f63862cc0123284) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2-javadoc.jar.asc >> > (SHA1: 18b70a1620eba89ad6b92228989aeb3c44fe566c) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2-javadoc.jar >> > (SHA1: 80c03e56d85019d509dd74c89bd124c10deee902) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2.pom >> > (SHA1: 906a4ac7b55f285784d19ec95da5d2d59c014687) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2.jar >> > (SHA1: 3f98d0479955196244e9acc1088dd7943cce182e) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2.jar.asc >> > (SHA1: 62fab3ee4935d9518030634493e579285be66cf5) >> > /org/apache/commons/commons-vfs2-examples/2.2/commons-vfs2- >> examples-2.2.pom.asc >> > (SHA1: efee055026dd0c6b51257f63de3ba3c783f5cce3) >> > >> > Get them: >> > >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.tar.gz.md5 >> > -o commons-vfs2-distribution-2.2-src.tar.gz.md5 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2.pom.md5 >> > -o commons-vfs2-distribution-2.2.pom.md5 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.tar.gz >> > -o commons-vfs2-distribution-2.2-src.tar.gz >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.zip.asc >> > -o commons-vfs2-distribution-2.2-bin.zip.asc >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2.pom >> > -o commons-vfs2-distribution-2.2.pom >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.zip.asc >> > -o commons-vfs2-distribution-2.2-src.zip.asc >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.zip >> > -o commons-vfs2-distribution-2.2-bin.zip >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.tar.gz.md5 >> > -o commons-vfs2-distribution-2.2-bin.tar.gz.md5 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2.pom.sha1 >> > -o commons-vfs2-distribution-2.2.pom.sha1 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.tar.gz >> > -o commons-vfs2-distribution-2.2-bin.tar.gz >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.zip.md5 >> > -o commons-vfs2-distribution-2.2-bin.zip.md5 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2.pom.asc >> > -o commons-vfs2-distribution-2.2.pom.asc >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.tar.gz.sha1 >> > -o commons-vfs2-distribution-2.2-bin.tar.gz.sha1 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.tar.gz.sha1 >> > -o commons-vfs2-distribution-2.2-src.tar.gz.sha1 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.zip.md5 >> > -o commons-vfs2-distribution-2.2-src.zip.md5 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.zip.sha1 >> > -o commons-vfs2-distribution-2.2-bin.zip.sha1 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.tar.gz.asc >> > -o commons-vfs2-distribution-2.2-src.tar.gz.asc >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.zip.sha1 >> > -o commons-vfs2-distribution-2.2-src.zip.sha1 >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-src.zip >> > -o commons-vfs2-distribution-2.2-src.zip >> > curl >> > https://repository.apache.org/service/local/repositories/org >> apachecommons-1266/content/org/apache/commons/commons-vfs2- >> distribution/2.2/commons-vfs2-distribution-2.2-bin.tar.gz.asc >> > -o commons-vfs2-distribution-2.2-bin.tar.gz.asc >> > >> > I have tested this with 7 and 8 using Maven 3.5.0 on Windows 10. >> > >> > Details of changes since 2.1 are in the release notes: >> > https://dist.apache.org/repos/dist/dev/commons/vfs/RELEASE-NOTES.txt >> > https://people.apache.org/~ggregory/vfs2/staging/changes-report.html >> > >> > Site: >> > https://people.apache.org/~ggregory/vfs2/staging/index.html >> > (note some *relative* links are broken and the 1.2 directories are >> > not yet created - these will be OK once the site is deployed) >> > >> > To run the Clirr Report (compared to 2.1, like 2.1, there is no Clirr >> > report generated): >> > mvn clirr:check -pl commons-vfs2 >> > >> > RAT Report: >> > https://people.apache.org/~ggregory/vfs2/staging/rat-report.html >> > >> > KEYS: >> > https://www.apache.org/dist/commons/KEYS >> > >> > Please review the release candidate and vote. >> > This vote will close no sooner that 72 hours from now, i.e. sometime >> after >> > 17:00 UTC 26 September 2017 >> > >> > [ ] +1 Release these artifacts >> > [ ] +0 OK, but... >> > [ ] -0 OK, but really should fix... >> > [ ] -1 I oppose this release because... >> > >> > Thanks! >> > >> > Gary Gregory >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> >>
