On 9 January 2018 at 12:30, Stephen Colebourne <scolebou...@joda.org> wrote: > This seems a lot more effort than just adding something to the pom.xml > in the child project. > Stephen
Agreed; it could be something as simple as a property define. Note that if it is a file, then it needs to be added to the source archive but ideally not the binary archive. This is already true of pom.xml > On 9 January 2018 at 12:11, Gilles <gil...@harfang.homelinux.org> wrote: >> Hi. >> >> My suggestion would be >> "profile.java_automatic_module_name" >> in the top directory. >> >> Gilles >> >> >> On Mon, 8 Jan 2018 22:23:08 -0800, Chas Honton wrote: >>> >>> Profile triggers in src/profiles? >>> >>> Chas >>> >>>> On Jan 8, 2018, at 4:27 PM, sebb <seb...@gmail.com> wrote: >>>> >>>>> On 8 January 2018 at 23:14, Jörg Schaible <joerg.schai...@gmx.de> wrote: >>>>> Am Mon, 08 Jan 2018 00:48:08 +0000 schrieb sebb: >>>>> >>>>>> On 8 January 2018 at 00:25, Jörg Schaible <joerg.schai...@gmx.de> >>>>>> wrote: >>>>> >>>>> >>>>> [snip] >>>>> >>>>>>>> The component poms I checked all include a comment like "Temporary >>>>>>>> fix, remove this after this has implemented in parent pom". As these >>>>>>>> comments are not true anymore I will remove those I find. >>>>>>> >>>>>>> >>>>>>> It is possible to define a profile in parent and trigger it as opt-in >>>>>>> based on the existence of a file. >>>>>>> >>>>>>> Do we have any precedence for triggering profiles based on file >>>>>>> existence in commons? Typical name patterns used are: >>>>>>> - profile/<name> - profiles/<name> >>>>>>> - <name>.profile >>>>>> >>>>>> >>>>>> Yes, e.g. jacoco >>>>> >>>>> >>>>> Found it: >>>>> >>>>> - src/site/resources/profile.<name> >>>>> >>>>> However the location for these profile files does not make sense in >>>>> general. And definitely not for a profile >>>>> adding the module name :-/ >>>>> >>>>> Alternatives? Common location for such a profile activation? >>>> >>>> >>>> src/site/resources was chosen because Jacoco is used for the site build. >>>> I don't think such files should should be moved. >>>> >>>> But by all means find somewhere else for new profile triggers. >>>> >>>>> Cheers, >>>>> Jörg >>>>> >>>>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org >> For additional commands, e-mail: dev-h...@commons.apache.org >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
